Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

get.sh: support dnf#6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
black-desk wants to merge1 commit intoxmake-io:dev
base:dev
Choose a base branch
Loading
fromblack-desk:support-dnf
Draft

Conversation

@black-desk
Copy link

Signed-off-by: Chen Linxuanme@black-desk.cn

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello@black-desk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances theget.sh script by integrating support for thednf package manager. This change broadens the script's compatibility, allowing users on Fedora, RHEL 8+, and CentOS Stream 8+ systems to seamlessly install necessary development dependencies. The update ensures a smoother setup experience across a wider array of Linux distributions.

Highlights

  • DNF Package Manager Support: Theget.sh script now includes support for thednf package manager, enabling automatic installation of development tools on systems using it.
  • Dependency Installation Logic: Theinstall_tools function has been updated to detectdnf and use it to installgit,readline-devel,bzip2, and the@development-tools group.
  • Improved Error Messaging: The dependency installation failure message has been updated to explicitly listdnf among the supported package managers, providing clearer guidance to users.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

  1. Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request adds support for thednf package manager to theget.sh installation script, which is a great improvement for users on modern Fedora-based distributions. The implementation is sound, and I have one suggestion to make thednf command more efficient by combining twoinstall calls into one. The change correctly updates the bootstrap script and the associated help message.

Signed-off-by: Chen Linxuan <me@black-desk.cn>
@waruqi
Copy link
Member

Does it ready now?

@black-desk
Copy link
Author

Does it ready now?

It seems to work on my machine.

But I am not sure about whether we actually install all dependencies we need here or not.

@waruqi
Copy link
Member

Does it ready now?

It seems to work on my machine.

But I am not sure about whether we actually install all dependencies we need here or not.

git,@development-tools is required, readline-devel is optional and is only needed for REPL, and bzip2 is also optional and is needed for package management.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@black-desk@waruqi
[8]ページ先頭
©2009-2025 Movatter.jp