Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Optionally match on username#90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xhiroga merged 1 commit intoxhiroga:feat/usernamefromtimle8n1:support-username
May 6, 2025

Conversation

timle8n1
Copy link
Contributor

Summary

Matches on username optional like region

Motivation

When accessing environments we have various roles that show up in the form of the username with SSO - this allows for changing the color based on the username/role - so edit contexts can be a different color than just read contexts

c24w reacted with thumbs up emojixhiroga reacted with eyes emoji
@xhiroga
Copy link
Owner

Thanks for the PR,@timle8n1 san! I have been busy and sorry for the late review.

I too think changing the color according to the username is a good idea. On the other hand, I was worried that if it becomes so multifunctional, there might be cases where you want to change the conditions for the label foreground and background.

Do you know of any UI management tools that allow such flexible settings, and what kind of setting strategies they use?

Note that the above concern is just a precaution, and I basically agree with PR's policy!

@timle8n1
Copy link
ContributorAuthor

Hey thanks for the reply. And thanks for the tool! My company recently switched from native AWS cross account roles that allow you to set the color of each role that is remembered.

They suggested this tool to replace the color switching that many of us were using. However I ran into the issue that I login to the same AWS account with two different roles (read only and admin effectively). This PR is just to scratch that itch, I’m not too sure what other tools might use.

I’m running personally on my fork of this and it’s working fine but totally understand if you don’t want to merge it. Whatever you decide, thanks for the tool - it works great!

xhiroga reacted with hooray emojixhiroga reacted with heart emoji

@xhiroga
Copy link
Owner

Thank you very much!

I see, you originally used native cross account roles. I used it myself, so I understand.
If you mean an alternative to that, it certainly seems like a simple matter of adding username to the condition. It may take some time, but I will review and add it as a feature.

Thank you for using this!

Copy link
Owner

@xhirogaxhiroga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@timle8n1 Reviewed PR.
I thought about comparing it to the existing Switch Role as well, but I think we should use roleName instead of userName.
Since userName is different for each user, roleName is more appropriate when the team is managing roles.
I will try to fix this PR when I have time, but of course you are welcome to fix it on your end!

@xhiroga
Copy link
Owner

@timle8n1 I have reconsidered. It is difficult to follow AWS specifications, so I am considering allowing the registration of regular expression patterns for UserName. I would like to keep your contribution, so I will start from this PR.

@xhirogaxhiroga changed the base branch frommain tofeat/usernameMay 6, 2025 05:31
@xhirogaxhiroga merged commit9fceb30 intoxhiroga:feat/usernameMay 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@xhirogaxhirogaxhiroga left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@timle8n1@xhiroga

[8]ページ先頭

©2009-2025 Movatter.jp