Movatterモバイル変換

Fix ordering of DROP TRIGGER statements in the filtered schema#588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Conversation

Copy link

Member

tsg commentedNov 8, 2025

Description

In a similar issue with#573 we're seeing error of this form:

ERROR: relation "public.table" does not exist

Which seem to come from DROP TRIGGER statmenets in the filtered schema like:

DROP TRIGGER IF EXISTS trigger_name ON public.table;

because it's called beforepublic.table is created.

Related Issue(s)

Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)

Type of Change

Please select the relevant option(s):

🐛 Bug fix (non-breaking change that fixes an issue)
✨ New feature (non-breaking change that adds functionality)
💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
📚 Documentation update
🔧 Refactoring (no functional changes)
⚡ Performance improvement
🧪 Test coverage improvement
🔨 Build/CI changes
🧹 Code cleanup

Changes Made

Testing

Unit tests added/updated
Integration tests added/updated
Manual testing performed
All existing tests pass

Checklist

Code follows project style guidelines
Self-review completed
Code is well-commented
Documentation updated where necessary

Additional Notes

Fix ordering of DROP TRIGGER statements in the filtered schema

6857680

tsg requested a review fromeminano

November 8, 2025 17:53

Copy link

github-actionsbot commentedNov 8, 2025

Merging this branch willnot change overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/xataio/pgstream/pkg/snapshot/generator/postgres/schema/pgdumprestore	90.14% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/xataio/pgstream/pkg/snapshot/generator/postgres/schema/pgdumprestore/snapshot_pg_dump_restore_generator.go	83.71% (ø)	264	221	43

Please note that the "Total", "Covered", and "Missed" counts above refer tocode statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Copy link

Collaborator

eminano commentedNov 10, 2025•
edited
Loading

This shouldn't happen. The drop statements are coming from the clean stage of the dump. The order should be valid unless the clean is enabled and the table doesn't exist, but even in that case, it shouldn't be preventing the dump, those errors should be ignored.

Can you share more details about what triggers this?

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix ordering of DROP TRIGGER statements in the filtered schema#588

Are you sure you want to change the base?

Fix ordering of DROP TRIGGER statements in the filtered schema#588

Uh oh!