Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[generator] Reference bound *Appearance types using global:: syntax. Fixes #6834.#6859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rolfbjarne merged 1 commit intodotnet:xcode11fromrolfbjarne:issue-6834
Aug 28, 2019

Conversation

@rolfbjarne
Copy link
Member

The generator will create special *Appearance types (these are nested
classes). If we've bound a type with the same *Appearance name, we can end up
in a situation where the csc compiler uses the the type we don't want due to
C#'s resolution rules - this happens if the bound *Appearance type is
referenced from the containing type of the special *Appearance type. So always
reference the bound *Appearance types using global:: syntax.

Fixes#6834.

…ixesdotnet#6834.The generator will create special *Appearance types (these are nestedclasses). If we've bound a type with the same *Appearance name, we can end upin a situation where the csc compiler uses the the type we don't want due toC#'s resolution rules - this happens if the bound *Appearance type isreferenced from the containing type of the special *Appearance type. So alwaysreference the bound *Appearance types using global:: syntax.Fixesdotnet#6834.
@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
⚠️API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️Generator Diff (please review changes)
Test run succeeded

@rolfbjarne
Copy link
MemberAuthor

The breaking API changes are all in new API.

@rolfbjarnerolfbjarne merged commit37e710c intodotnet:xcode11Aug 28, 2019
@rolfbjarnerolfbjarne added the bugIf an issue is a bug or a pull request a bug fix labelAug 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dalexsotodalexsotodalexsoto approved these changes

+2 more reviewers

@spouliotspouliotspouliot approved these changes

@VincentDondainVincentDondainVincentDondain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugIf an issue is a bug or a pull request a bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rolfbjarne@monojenkins@dalexsoto@spouliot@VincentDondain

[8]ページ先頭

©2009-2025 Movatter.jp