- Notifications
You must be signed in to change notification settings - Fork548
[safariservices] Update for Xcode 11 beta 1 to 5#6767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Also introduce `PlatformName.MacCatalyst` while keeping the old`UIKitForMac`, with the same value, until we can clean up existingbindings globally (and without too much conflicts).
rolfbjarne approved these changesAug 14, 2019
dalexsoto approved these changesAug 14, 2019
Collaborator
monojenkins commentedAug 14, 2019
Build success |
spouliot pushed a commit to spouliot/xamarin-macios that referenced this pull requestAug 15, 2019
The `enum` is decorated with `[Obsolete]` since it's unused by any API.However recent logic skips obsolete members it so it looks missing...even if it won't be removed until `XAMCORE_4_0` is enabled.Not quite clear why the original PR [1] did not report it... but allsubsequent ones aredotnet#6767
spouliot added a commit that referenced this pull requestAug 15, 2019
…OS (#6776)The `enum` is decorated with `[Obsolete]` since it's unused by any API.However recent logic skips obsolete members it so it looks missing...even if it won't be removed until `XAMCORE_4_0` is enabled.Not quite clear why the original PR [1] did not report it... but allsubsequent ones are#6767
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also introduce
PlatformName.MacCatalystwhile keeping the oldUIKitForMac, with the same value, until we can clean up existingbindings globally (and without too much conflicts).