NotificationsYou must be signed in to change notification settings
Fork548
Star2.8k

[externalaccessory] Update for Xcode 11 beta 5#6746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

spouliot merged 2 commits intodotnet:xcode11fromspouliot:xcode11-externalaccessory-b5

Aug 12, 2019

Merged

[externalaccessory] Update for Xcode 11 beta 5#6746

spouliot merged 2 commits intodotnet:xcode11fromspouliot:xcode11-externalaccessory-b5

Aug 12, 2019

Conversation

Copy link

Contributor

spouliot commentedAug 9, 2019

No description provided.

[externalaccessory] Update for Xcode 11 beta 5

29f0211

spouliot requested a review fromdalexsoto as acode owner

August 9, 2019 19:38

spouliot added the enhancementThe issue or pull request is an enhancement label

Aug 9, 2019

spouliot added this to thexcode11 milestone

Aug 9, 2019

VincentDondain approved these changes

Aug 9, 2019

View reviewed changes

Copy link

Contributor

VincentDondain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's debatable but I feel it might be interesting to mention that it'sNo longer supported, in opposition to "deprecated for something else". Making that explicit to the user when autocompleting might be valuable.

Fix macOS version for deprecation

aecfbb4

Copy link

ContributorAuthor

spouliot commentedAug 9, 2019

I rather have the default / empty text when no alternative is suggested. That goes back to the original meaning, i.e. "{Apple} does not approve", without bloating the assemblies with strings that might not be (or remain) accurate.