- Notifications
You must be signed in to change notification settings - Fork548
[UIKit] Update bindings to Xcode 11 Beta 5#6717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
monojenkins commentedAug 6, 2019
Build success |
dalexsoto commentedAug 6, 2019
Breaking changes expected on new type |
| [Export ("activityItemsConfigurationMetadataForKey:")] | ||
| [return: NullAllowed] | ||
| NSObject GetActivityItemsConfigurationMetadata (NSString activityItemsConfigurationMetadataKey); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we have an enum for this keys? Use a smart enum, expose the string one as an advance one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can't because this is a protocol :)
| NSItemProvider [] ItemProvidersForActivityItemsConfiguration { get; } | ||
| [Export ("activityItemsConfigurationSupportsInteraction:")] | ||
| bool GetActivityItemsConfigurationSupportsInteraction (NSString activityItemsConfigurationInteraction); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we have an enum for this and then expose the string one for advance users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can't because this is a protocol :)
| [Export ("activityItemsConfigurationPreviewForItemAtIndex:intent:suggestedSize:")] | ||
| [return: NullAllowed] | ||
| NSItemProvider GetActivityItemsConfigurationPreview (nint index, NSString activityItemsConfigurationPreviewIntent, CGSize suggestedSize); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In all the methods, or most of them we haveGetActivityItemsConfiguration then either preview or metadata. Can we just use GetMetadata and GetPreview?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can't because this is a protocol :) Also I think the name is important because this is a protocol and can be implemented by several, also I think this avoids a round trip to documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
and also goes by hand with the propertyItemProvidersForActivityItemsConfiguration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Meh.. I'm going to accept it because Swift uses the same.. but what a horrible name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
And swift uses the same
optional func activityItemsConfigurationPreviewForItem(at index: Int, intent: UIActivityItemsConfigurationPreviewIntent, suggestedSize: CGSize) -> NSItemProvider?
No description provided.