- Notifications
You must be signed in to change notification settings - Fork548
[Xcode11] [carplay] Updates for beta 5#6678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Xcode11] [carplay] Updates for beta 5#6678
Uh oh!
There was an error while loading.Please reload this page.
Conversation
monojenkins commentedJul 29, 2019
Build failure Test results2 tests failed, 89 tests passed.Failed tests
|
spouliot commentedAug 13, 2019
why was this closed ? I can't see another PR with the changes (which mostly look correct, once xtro data is updated) |
monojenkins commentedAug 13, 2019
Build failure Test results14 tests failed, 77 tests passed.Failed tests
|
monojenkins commentedAug 13, 2019
Build failure Test results1 tests failed, 90 tests passed.Failed tests
|
spouliot commentedAug 29, 2019
@whitneyschmidt so looking at a recent PR you can see that the API is still missing You should have the same result by running xtro locally. |
This reverts commit 851a424557001c865b8dfe62c920f132cf84db06.
…amarin-macios into carplay_update
whitneyschmidt commentedAug 29, 2019
@spouliot - this should be good to go once build/test validation comes back. I checked xtro results locally :) Don't look at the commit history... |
spouliot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is why I ❤️ github's "squash and merge" feature :)
dalexsoto commentedAug 29, 2019
Yup better than doing it manually like some time ago :) |
monojenkins commentedAug 30, 2019
Build success |
No description provided.