NotificationsYou must be signed in to change notification settings
Fork548
Star2.8k

[xcode11] [IntentsUI] bindings for iOS beta1#6625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dalexsoto merged 7 commits intodotnet:xcode11fromjoconte:xcode11-IntentsUI-iOS-b1

Jul 25, 2019

Merged

[xcode11] [IntentsUI] bindings for iOS beta1#6625

dalexsoto merged 7 commits intodotnet:xcode11fromjoconte:xcode11-IntentsUI-iOS-b1

Jul 25, 2019

Conversation

Copy link

Contributor

joconte commentedJul 21, 2019

diff :https://github.com/xamarin/xamarin-macios/wiki/IntentsUI-iOS-xcode11-beta1

joconte added2 commits

July 21, 2019 15:32

updated bindings

166acbf

updated bindings

62329ac

joconte requested a review fromdalexsoto as acode owner

July 21, 2019 13:40

delete todo file

47dee8e

joconte requested a review fromspouliot as acode owner

July 21, 2019 13:45

tj-devel709 reviewed

Jul 22, 2019

View reviewed changes

src/intentsui.cs OutdatedShow resolvedHide resolved

fix iOS version on enum

c9417a3

Copy link

ContributorAuthor

joconte commentedJul 22, 2019

I need to addINUICompat.cs tosrc/frameworks.sources.

Add to frameworks.sources to remove breaking change

dd1717c

Copy link

Contributor

monojenkins commentedJul 22, 2019

Build failure
✅Build succeeded
✅API Diff (from stable)
⚠️API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️Generator Diff (please review changes)
🔥Test run failed 🔥

Test results

7 tests failed, 84 tests passed.

Failed tests

Xtro/Mac: Failed (Test run failed.)
monotouch-test/iOS Unified 32-bits - simulator/Debug: BuildFailure
monotouch-test/iOS Unified 32-bits - simulator/Debug (static registrar): BuildFailure
monotouch-test/iOS Unified 32-bits - simulator/Release (all optimizations): BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): BuildFailure

rolfbjarne requested changes

Jul 23, 2019

View reviewed changes

Copy link

Member

rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I looked at the header diff, and there are a few other places where Apple marked API as unavailable on uikitformac, so the corresponding attributes should be added to our code as well.

The diff chunks that marks IntentsUI as unavailable on macOS can be ignored, since IntentsUI isn't present on macOS anyway (these header changes seem to indicate that IntentsUI might be added to macOS in the future though).