- Notifications
You must be signed in to change notification settings - Fork548
[IncomingCallNotifications] Add Xcode 11 Beta 1 & Beta 2 bindings#6374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
chamons left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Depending on iOS vs macOS (does it work on mac) we might need to rip out the mac parts?
| boolIsEqual(ICHandlehandle); | ||
| } | ||
| [iOS(13,0),Mac(10,15,onlyOn64:true)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Headers only seem to show this for:
+IC_CLASS_AVAILABLE(ios(13.0))+@interface ICNotification : NSObject <NSCopying>Did I miss something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@chamons The framework does exist in the SDK/Applications/Xcode11-beta1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/IncomingCallNotifications.framework and I can confirm that it exists in Catalina. It kind of makes sense since you can pair your Mac with your phone and answer calls in your computer or use FaceTime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree, but it's not in the headers fwict?
I hate to bind it and have them remove it later?
File radar and make iOS only? Or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
mmm since it makes sense I would leave as is but lets have some middle ground here we can file an issue about this and keep track of it in new betas, would this suggestion work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's fine. Add it for now, add removing it in#6212 if not in header. Maybe file a radar for bonus points?
dalexsoto left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
After comments are fixed
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
5b6b5a5 to1fb67e0Comparetj-devel709 commentedJun 21, 2019
Okay I had a weird issue pushing and Alex helped me fix my branch so the changes recommended should be good now.@dalexsoto@rolfbjarne@spouliot@mandel-macaque@VincentDondain@chamons |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
dalexsoto commentedJun 24, 2019
build |
monojenkins commentedJun 24, 2019
Build failure Test results2 tests failed, 92 tests passed.Failed tests
|
Removed from build indotnet#6480This PR only removes the (now unused) bindings file.Original PR:dotnet#6374
No description provided.