Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[coregraphics] Update for Xcode 11 beta 1 and 2#6337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spouliot merged 5 commits intodotnet:xcode11fromspouliot:xcode11-coregraphics-b1
Jun 19, 2019

Conversation

@spouliot
Copy link
Contributor

along with unit tests for p/invokes

along with unit tests for p/invokes
@monojenkins
Copy link
Collaborator

Build failure
✅Build succeeded
✅API Diff (from stable)
ℹ️API Diff (from PR only) (please review changes)
ℹ️Generator Diff (please review changes)
🔥Test run failed 🔥

Test results

3 tests failed, 84 tests passed.

Failed tests

  • mono-native-compat/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • mono-native-unified/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • MSBuild tests/iOS: Failed (Execution failed with exit code 1)

[iOS(13,0)]
[TV(13,0)]
[Watch(6,0)]
publicCGColorConversionInfo(CGColorSpacesrc,CGColorSpacedst,NSDictionaryoptions)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor: parameter names should not be abbreviated (src ->source,dst ->destination).

[iOS(13,0)]
[TV(13,0)]
[Watch(6,0)]
publicCGColorConversionInfo(CGColorSpacesrc,CGColorSpacedst,CGColorConversionOptionsoptions):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Same: parameter names.

@monojenkins
Copy link
Collaborator

Build failure
✅Build succeeded
✅API Diff (from stable)
⚠️API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️Generator Diff (please review changes)
🔥Test run failed 🔥

Test results

7 tests failed, 84 tests passed.

Failed tests

  • xammac tests/Mac Unified/Debug: Failed (Test run crashed (exit code: 134).)
  • xammac tests/Mac Unified/Release (all optimizations): Failed (Test run crashed (exit code: 134).)
  • mono-native-compat/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • mono-native-unified/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • introspection/tvOS - simulator/Debug (tvOS 10.2): Failed
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 3.2): Failed
  • MSBuild tests/iOS: Failed (Execution failed with exit code 1)

@spouliotspouliot added the do-not-mergeDo not merge this pull request labelJun 17, 2019
@spouliot
Copy link
ContributorAuthor

I'll update it for beta2 before merging it

@monojenkins
Copy link
Collaborator

Build failure
✅Build succeeded
✅API Diff (from stable)
⚠️API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️Generator Diff (please review changes)
🔥Test run failed 🔥

Test results

3 tests failed, 88 tests passed.

Failed tests

  • mono-native-compat/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • mono-native-unified/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • MSBuild tests/iOS: Failed (Execution failed with exit code 1)

@spouliotspouliot removed the do-not-mergeDo not merge this pull request labelJun 18, 2019
@spouliotspouliot changed the title[coregraphics] Update for Xcode 11 beta 1[coregraphics] Update for Xcode 11 beta 1 and 2Jun 18, 2019
@spouliotspouliot added this to thexcode11 milestoneJun 18, 2019
@monojenkins
Copy link
Collaborator

Build failure
✅Build succeeded
✅API Diff (from stable)
⚠️API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️Generator Diff (please review changes)
🔥Test run failed 🔥

Test results

3 tests failed, 88 tests passed.

Failed tests

  • mono-native-compat/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • mono-native-unified/Mac Unified/Modern: Failed (Test run crashed (exit code: 134).)
  • MSBuild tests/iOS: Failed (Execution failed with exit code 1)

@spouliot
Copy link
ContributorAuthor

@spouliotspouliot merged commitfee66b3 intodotnet:xcode11Jun 19, 2019
@spouliotspouliot deleted the xcode11-coregraphics-b1 branchJune 19, 2019 00:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dalexsotodalexsotodalexsoto approved these changes

@rolfbjarnerolfbjarnerolfbjarne approved these changes

+1 more reviewer

@whitneyschmidtwhitneyschmidtwhitneyschmidt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

xcode11

Development

Successfully merging this pull request may close these issues.

5 participants

@spouliot@monojenkins@dalexsoto@rolfbjarne@whitneyschmidt
[8]ページ先頭
©2009-2025 Movatter.jp