Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Updated standards and fixed problems with python 3.8#57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
claudiosanches merged 1 commit intowoocommerce:masterfromEvert-Arends:patch-1
Mar 13, 2021

Conversation

@Evert-Arends
Copy link
Contributor

  • Updated version
  • Removed percentage operator in favor of f-strings
  • Added HTTPBasicAuth to auth for stricter reading
  • Removed python from HTTPBasicAuth header, to make this API work with the latest version of python.

freddie-freeloader and claudiosanches reacted with thumbs up emojifreddie-freeloader reacted with hooray emoji
- Updated version- Removed percentage operator in favor of f-strings- Added HTTPBasicAuth to auth for stricter reading- Removed python from HTTPBasicAuth header, to make this API work with the latest version of python.
@Evert-ArendsEvert-Arends mentioned this pull requestOct 8, 2020
Copy link
Contributor

@claudiosanchesclaudiosanches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems like unit test aren't working anymore for older versions of Python.
Still not sure if we could drop support for those.
Thanks for your help.

@Evert-Arends
Copy link
ContributorAuthor

I do think support for python2.7 should be dropped, as python2.7 is not supported anymore.

However for python 3.5 this could be used:https://stackoverflow.com/questions/55182209/f-string-invalid-syntax-in-python-3-5

You could technically remove the fstring for string format, but that is less future proof.

Thanks for taking a look at this.

Best regards

claudiosanches reacted with thumbs up emoji

@claudiosanches
Copy link
Contributor

@Evert-Arends I agree with you, let's set only what is currently supported by Python only.

Copy link
Contributor

@claudiosanchesclaudiosanches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your help, and for inspiring me to drop support to older Python versions.

Evert-Arends reacted with laugh emoji
@claudiosanchesclaudiosanches merged commit081b392 intowoocommerce:masterMar 13, 2021
@Evert-Arends
Copy link
ContributorAuthor

Thanks for merging, much appreciated!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@claudiosanchesclaudiosanchesclaudiosanches approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Evert-Arends@claudiosanches
[8]ページ先頭
©2009-2025 Movatter.jp