Commitad3726e

authored

fix: fix repoContrib confusion (anuraghazra#2269) (anuraghazra#2274)

This commit prevents confusion about the Contributed to stat. Currently,only the last year's results are shown, but it looks like it is theall-time contribution count (seeanuraghazra#2269). This commit adds a ' (last year)'suffix to prevent this confusion from happening.

1 parent0efb982 commitad3726eCopy full SHA for ad3726e

File tree

2 files changed

-3

lines changed

src/cards
- stats-card.js
tests
- renderStatsCard.test.js

2 files changed

-3

lines changed

`‎src/cards/stats-card.js`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ const renderStatsCard = (stats = {}, options = { hide: [] }) => {`
`154`	`154`	`},`
`155`	`155`	`contribs:{`
`156`	`156`	`icon:icons.contribs,`
`157`		`-label:i18n.t("statcard.contribs"),`
	`157`	`+label:i18n.t("statcard.contribs")+" (last year)",`
`158`	`158`	`value:contributedTo,`
`159`	`159`	`id:"contribs",`
`160`	`160`	`},`
`@@ -186,7 +186,7 @@ const renderStatsCard = (stats = {}, options = { hide: [] }) => {`
`186`	`186`	`index,`
`187`	`187`	`showIcons:show_icons,`
`188`	`188`	`shiftValuePos:`
`189`		`-(!include_all_commits ?50 :35)+(isLongLocale ?50 :0),`
	`189`	`+(!include_all_commits ?79.01 :35)+(isLongLocale ?50 :0),`
`190`	`190`	`bold:text_bold,`
`191`	`191`	`}),`
`192`	`192`	`);`

`‎tests/renderStatsCard.test.js`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,7 @@ describe("Test renderStatsCard", () => {`
`344`	`344`	`document.querySelector(`
`345`	`345`	`'g[transform="translate(0, 100)"]>.stagger>.stat.bold',`
`346`	`346`	`).textContent,`
`347`		-).toMatchInlineSnapshot(`"参与项目数:"`);
	`347`	+).toMatchInlineSnapshot(`"参与项目数 (last year):"`);
`348`	`348`	`});`
`349`	`349`
`350`	`350`	`it("should render without rounding",()=>{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitad3726e

File tree

2 files changed

2 files changed

`‎src/cards/stats-card.js`

`‎tests/renderStatsCard.test.js`

0 commit comments