Commit5df25a6

authored

fix: improve boolean parse behaviour (anuraghazra#2029)

1 parent4b656eb commit5df25a6Copy full SHA for 5df25a6

File tree

+29

-8

lines changed

+29

-8

lines changed

Lines changed: 11 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -77,17 +77,20 @@ const isValidHexColor = (hexColor) => {`
`77`	`77`	`/**`
`78`	`78`	`* Returns boolean if value is either "true" or "false" else the value as it is.`
`79`	`79`	`*`
`80`		`- *@param {string} value The value to parse.`
`81`		`- *@returns {boolean \|string} The parsed value.`
	`80`	`+ *@param {string \| boolean} value The value to parse.`
	`81`	`+ *@returns {boolean \|undefined} The parsed value.`
`82`	`82`	`*/`
`83`	`83`	`constparseBoolean=(value)=>{`
`84`		`-if(value==="true"){`
`85`		`-returntrue;`
`86`		`-}elseif(value==="false"){`
`87`		`-returnfalse;`
`88`		`-}else{`
`89`		`-returnvalue;`
	`84`	`+if(typeofvalue==="boolean")returnvalue;`
	`85`	`+`
	`86`	`+if(typeofvalue==="string"){`
	`87`	`+if(value.toLowerCase()==="true"){`
	`88`	`+returntrue;`
	`89`	`+}elseif(value.toLowerCase()==="false"){`
	`90`	`+returnfalse;`
	`91`	`+}`
`90`	`92`	`}`
	`93`	`+returnundefined;`
`91`	`94`	`};`
`92`	`95`
`93`	`96`	`/**`

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ import {`
`4`	`4`	`encodeHTML,`
`5`	`5`	`getCardColors,`
`6`	`6`	`kFormatter,`
	`7`	`+parseBoolean,`
`7`	`8`	`renderError,`
`8`	`9`	`wrapTextMultiline,`
`9`	`10`	`}from"../src/common/utils.js";`
`@@ -19,6 +20,23 @@ describe("Test utils.js", () => {`
`19`	`20`	`expect(kFormatter(9900000)).toBe("9900k");`
`20`	`21`	`});`
`21`	`22`
	`23`	`+it("should test parseBoolean",()=>{`
	`24`	`+expect(parseBoolean(true)).toBe(true);`
	`25`	`+expect(parseBoolean(false)).toBe(false);`
	`26`	`+`
	`27`	`+expect(parseBoolean("true")).toBe(true);`
	`28`	`+expect(parseBoolean("false")).toBe(false);`
	`29`	`+expect(parseBoolean("True")).toBe(true);`
	`30`	`+expect(parseBoolean("False")).toBe(false);`
	`31`	`+expect(parseBoolean("TRUE")).toBe(true);`
	`32`	`+expect(parseBoolean("FALSE")).toBe(false);`
	`33`	`+`
	`34`	`+expect(parseBoolean("1")).toBe(undefined);`
	`35`	`+expect(parseBoolean("0")).toBe(undefined);`
	`36`	`+expect(parseBoolean("")).toBe(undefined);`
	`37`	`+expect(parseBoolean(undefined)).toBe(undefined);`
	`38`	`+});`
	`39`	`+`
`22`	`40`	`it("should test encodeHTML",()=>{`
`23`	`41`	expect(encodeHTML(`<html>hello world<,.#4^&^@%!))`)).toBe(
`24`	`42`	`"<html>hello world<,.#4^&^@%!))",`

Comments

(0)