Commit26cde6b

fjosw

and

rickstaa

authored

Missing term in calculation of TOTAL_VALUES. (anuraghazra#2116)

* fix: added missing term in calculation of TOTAL_VALUES.* fix: fix rank test* refactor: update code formatting* refactor: update code formattingCo-authored-by: rickstaa <rick.staa@outlook.com>

1 parent1a4e5a6 commit26cde6bCopy full SHA for 26cde6b

File tree

3 files changed

-3

lines changed

src
- calculateRank.js
tests
- calculateRank.test.js
- e2e
  - e2e.test.js

3 files changed

-3

lines changed

`‎src/calculateRank.js`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,11 @@ function calculateRank({`
`70`	`70`	`constRANK_B_VALUE=100;`
`71`	`71`
`72`	`72`	`constTOTAL_VALUES=`
`73`		`-RANK_S_VALUE+RANK_A2_VALUE+RANK_A3_VALUE+RANK_B_VALUE;`
	`73`	`+RANK_S_VALUE+`
	`74`	`+RANK_DOUBLE_A_VALUE+`
	`75`	`+RANK_A2_VALUE+`
	`76`	`+RANK_A3_VALUE+`
	`77`	`+RANK_B_VALUE;`
`74`	`78`
`75`	`79`	`// prettier-ignore`
`76`	`80`	`constscore=(`

`‎tests/calculateRank.test.js`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,6 @@ describe("Test calculateRank", () => {`
`13`	`13`	`prs:300,`
`14`	`14`	`issues:200,`
`15`	`15`	`}),`
`16`		`-).toStrictEqual({level:"A+",score:49.16605417270399});`
	`16`	`+).toStrictEqual({level:"A+",score:49.25629684876535});`
`17`	`17`	`});`
`18`	`18`	`});`

`‎tests/e2e/e2e.test.js`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ const STATS_DATA = {`
`22`	`22`	`contributedTo:2,`
`23`	`23`	`rank:{`
`24`	`24`	`level:"A+",`
`25`		`-score:51.01013099671447,`
	`25`	`+score:50.900829325065935,`
`26`	`26`	`},`
`27`	`27`	`};`
`28`	`28`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit26cde6b

File tree

3 files changed

3 files changed

`‎src/calculateRank.js`

`‎tests/calculateRank.test.js`

`‎tests/e2e/e2e.test.js`

0 commit comments