Commit0caa4c5

authored

test: fix mistaken pageInfo.endCursor keys (anuraghazra#2657)

The previous mock logic was too simplistic and has been fixed in thecommit. If the mock logic had been properly implemented, then themistaken pageInfo.endCursor keys should have made the test case "shouldfetch two pages of stars if 'FETCH_MULTI_PAGE_STARS' env variable is setto `true`" stuck.

1 parent0c2fe4e commit0caa4c5Copy full SHA for 0caa4c5

File tree

2 files changed

+10

-9

lines changed

tests
- api.test.js
- fetchStats.test.js

2 files changed

+10

-9

lines changed

`‎tests/api.test.js`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ const data_stats = {`
`43`	`43`	`nodes:[{stargazers:{totalCount:100}}],`
`44`	`44`	`pageInfo:{`
`45`	`45`	`hasNextPage:false,`
`46`		`-cursor:"cursor",`
	`46`	`+endCursor:"cursor",`
`47`	`47`	`},`
`48`	`48`	`},`
`49`	`49`	`},`

`‎tests/fetchStats.test.js`

Lines changed: 9 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ const data_stats = {`
`27`	`27`	`],`
`28`	`28`	`pageInfo:{`
`29`	`29`	`hasNextPage:true,`
`30`		`-cursor:"cursor",`
	`30`	`+endCursor:"cursor",`
`31`	`31`	`},`
`32`	`32`	`},`
`33`	`33`	`},`
`@@ -44,7 +44,7 @@ const data_repo = {`
`44`	`44`	`],`
`45`	`45`	`pageInfo:{`
`46`	`46`	`hasNextPage:false,`
`47`		`-cursor:"cursor",`
	`47`	`+endCursor:"cursor",`
`48`	`48`	`},`
`49`	`49`	`},`
`50`	`50`	`},`
`@@ -64,7 +64,7 @@ const data_repo_zero_stars = {`
`64`	`64`	`],`
`65`	`65`	`pageInfo:{`
`66`	`66`	`hasNextPage:true,`
`67`		`-cursor:"cursor",`
	`67`	`+endCursor:"cursor",`
`68`	`68`	`},`
`69`	`69`	`},`
`70`	`70`	`},`
`@@ -86,11 +86,12 @@ const mock = new MockAdapter(axios);`
`86`	`86`
`87`	`87`	`beforeEach(()=>{`
`88`	`88`	process.env.FETCH_MULTI_PAGE_STARS="false";// Set to `false` to fetch only one page of stars.
`89`		`-mock`
`90`		`-.onPost("https://api.github.com/graphql")`
`91`		`-.replyOnce(200,data_stats)`
`92`		`-.onPost("https://api.github.com/graphql")`
`93`		`-.replyOnce(200,data_repo);`
	`89`	`+mock.onPost("https://api.github.com/graphql").reply((cfg)=>{`
	`90`	`+return[`
	`91`	`+200,`
	`92`	`+cfg.data.includes("contributionsCollection") ?data_stats :data_repo,`
	`93`	`+];`
	`94`	`+});`
`94`	`95`	`});`
`95`	`96`
`96`	`97`	`afterEach(()=>{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0caa4c5

File tree

2 files changed

2 files changed

`‎tests/api.test.js`

`‎tests/fetchStats.test.js`

0 commit comments