- Notifications
You must be signed in to change notification settings - Fork488
Upgrade to typescript 2.4 and ts-loader 2.2.1#94
Uh oh!
There was an error while loading.Please reload this page.
Conversation
wmonk commentedJun 30, 2017
@frederickfogerty as you can see the tests failed! Something was wrong with the If you check#74 we are having a discussion about moving to awesome-typescript-loader. |
DorianGrey commentedJul 5, 2017
The error the Travis build complains about refers to the react typings in use. This error was always present, it's just that typescript was unable to detect it properly before 2.4, which introduced improved checks for generics. However, the types used here seem to be outdated - the line mentioned does no longer exist. I can confirm that this error is not present using the most typings for react, i.e. |
Ts-loader version 2.2.1 is the minimum version required to work on typescript 2.4.1, seeTypeStrong/ts-loader#566 for more details.
fd81872 to1760cbbComparefrederickfogerty commentedJul 5, 2017
@DorianGrey thanks for that! I was waiting for that fix to come through. @wmonk the build is now passing after updating the |
gyzerok commentedJul 7, 2017
Hi folks! I am really looking forward for this to be merged since I need exactly this better generics type checks from 2.4 :) |
Uh oh!
There was an error while loading.Please reload this page.
Ts-loader version 2.2.1 is the minimum version required to work on typescript 2.4.1, seeTypeStrong/ts-loader#566 for more details.
I'm not sure how I can test or verify my changes. Are there any tests I can run, or anyway to run it in a CRA project?