Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

Upgrade to typescript 2.4 and ts-loader 2.2.1#94

Merged
wmonk merged 2 commits intowmonk:masterfromfrederickfogerty:master
Jul 11, 2017

Conversation

@frederickfogerty
Copy link
Contributor

@frederickfogertyfrederickfogerty commentedJun 30, 2017
edited
Loading

Ts-loader version 2.2.1 is the minimum version required to work on typescript 2.4.1, seeTypeStrong/ts-loader#566 for more details.


I'm not sure how I can test or verify my changes. Are there any tests I can run, or anyway to run it in a CRA project?

@wmonk
Copy link
Owner

@frederickfogerty as you can see the tests failed! Something was wrong with the@types when TS was upgraded the other day. To test you can runsh tasks/e2e-simple.sh to test this stuff locally.

If you check#74 we are having a discussion about moving to awesome-typescript-loader.

@DorianGrey
Copy link
Collaborator

The error the Travis build complains about refers to the react typings in use.

/home/travis/build/wmonk/create-react-app-typescript/node_modules/@types/react/index.d.ts(181,11): error TS2559: Type 'Component<P, S>' has no properties in common with type 'ComponentLifecycle<P, S>'.

This error was always present, it's just that typescript was unable to detect it properly before 2.4, which introduced improved checks for generics.

However, the types used here seem to be outdated - the line mentioned does no longer exist. I can confirm that this error is not present using the most typings for react, i.e."@types/react": "^15.0.34".

frederickfogerty reacted with thumbs up emoji

Ts-loader version 2.2.1 is the minimum version required to work on typescript 2.4.1, seeTypeStrong/ts-loader#566 for more details.
@frederickfogertyfrederickfogertyforce-pushed themaster branch 2 times, most recently fromfd81872 to1760cbbCompareJuly 5, 2017 20:56
@frederickfogerty
Copy link
ContributorAuthor

@DorianGrey thanks for that! I was waiting for that fix to come through.

@wmonk the build is now passing after updating the@types/react dependency

@gyzerok
Copy link

Hi folks!

I am really looking forward for this to be merged since I need exactly this better generics type checks from 2.4 :)

pcourt reacted with thumbs up emoji

@wmonkwmonk merged commit7395212 intowmonk:masterJul 11, 2017
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@wmonkwmonkwmonk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frederickfogerty@wmonk@DorianGrey@gyzerok

[8]ページ先頭

©2009-2025 Movatter.jp