This repository was archived by the owner on Jan 26, 2019. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork488
Add Sass Support (#2)#411
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
# Conflicts:#packages/react-scripts/package.json
Collaborator
DorianGrey commentedOct 1, 2018
Suppose this will be superseded by the upstream merge, which will contain the "original" |
Author
johnrom commentedOct 1, 2018
You're correct, that wasn't open when I initially PR'd the original SASS PR. Closing. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I merged#362 with the latest master, and changed it to use the official
create-react-app's SASS implementation.Run this, install
node-sassin your test project, and you should be able to use.scssfiles instead of.cssfiles.I tried to add component support fullyusing this, but unfortunately the typings project didn't work correctly. Components will technically work, but we won't get types for them.