Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

Update ts-jest 22.0.1 -> 23.10.3#410

Open
kdela wants to merge3 commits intowmonk:master
base:master
Choose a base branch
Loading
fromkdela:master
Open

Conversation

@kdela
Copy link

Update ts-jest version from 22.0.1 to 23.10.3

#399

Copy link
Contributor

@r3nyar3nya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link
Contributor

@r3nyar3nya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

Copy link

@ArelavArelav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wanted to create the same PR.
Also it requires to chage:

'^.+\\.tsx?$': resolve('config/jest/typescriptTransform.js'),

to just

 "^.+\\.tsx?$": "ts-jest",

according to this warning
ts-jest[main] (WARN) Replace any occurrences of "ts-jest/dist/preprocessor.js" or "<rootDir>/node_modules/ts-jest/preprocessor.js" in the 'transform' section of your Jest config with just "ts-jest".

@DorianGrey
Copy link
Collaborator

DorianGrey commentedOct 11, 2018•
edited
Loading

We've used the custom typescript transform file as a wrapper forts-jest in the past because there were some issue with properly resolving the transformer in both non-ejected and ejected mode. However, CI indicates that it works fine with just usingts-jest, which should achieve the same we've used the wrapper for previously.

Just one issue left:ts-jest now complains that thejest version in use is not tested. It is still pinned to 20.0.4, and I'm not sure why - anyway, I think it'd be better to get rid of this warning. Would you mind updatingjest as well (23.6 should be the most recent) and remove the pin?

@Arelav
Copy link

Arelav commentedOct 11, 2018•
edited
Loading

@DorianGrey Also we have to removeconfig/jest/typescriptTransform.js as well if it's not in use anymore.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

2 more reviewers

@ArelavArelavArelav left review comments

@r3nyar3nyar3nya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kdela@DorianGrey@Arelav@r3nya
[8]ページ先頭
©2009-2025 Movatter.jp