Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

Add SASS support#362

Open
thefill wants to merge3 commits intowmonk:master
base:master
Choose a base branch
Loading
fromthefill:master
Open

Add SASS support#362

thefill wants to merge3 commits intowmonk:masterfromthefill:master

Conversation

@thefill
Copy link

I have noticed .scss files are not supported in your fork - I have altered configs so css/scss files are compiled via webpack (no need for external sass compiler).

Bogala, nscarcella, mondayCoding, jEnbuska, ColinLeahy, and etulo reacted with thumbs up emoji
@Bogala
Copy link

It lacks a dependency to node-sass package.

thefill reacted with thumbs up emoji

@thefill
Copy link
Author

@Bogala thanks a lot for pointing this out - will take a look at this.

@thefill
Copy link
Author

@Bogala dependency added - one of the global packages must have fulfilled this dependency. Thanks again!

Bogala reacted with thumbs up emoji

@BogalaBogala mentioned this pull requestJul 13, 2018
@thefill
Copy link
Author

@Bogala looks like travis-ci failure is due to to issue with "npm cache clean". Can we execute CI again?

@thefill
Copy link
Author

Apparently npm cache clean should be run with --force. More about this issuehere

@clakech
Copy link

what about node-sass-chokidar ?

thefill reacted with thumbs up emoji

@thefill
Copy link
Author

@clakech that is indeed a valid replacement - in fact, its recommended in "react-create-app" doc. Thanks

@Bogala
Copy link

@thefill it is anissue node-sass with npm5. Use node-sass-chokidar will surely allow to pass the CI job

thefill reacted with heart emoji

@thefill
Copy link
Author

@Bogala just done that! thanks@Bogala &@clakech for the assistance ;-)

Bogala reacted with thumbs up emojiclakech reacted with heart emoji

@thefill
Copy link
Author

Any chance to merge this pr ? ;-)

@clakech
Copy link

clakech commentedJul 21, 2018 via email

Oh yes pleaseLe sam. 21 juil. 2018 à 01:08, Filip Dabrowski <notifications@github.com> aécrit :
Any chance to merge this pr ? ;-) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#362 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHXhn0cNWXPjPie6sDjq3Y87hc0ZXHUks5uImMFgaJpZM4VNUBB> .
-- Cyril Lakech

@DorianGrey
Copy link
Collaborator

This fork aims to maintain feature parity with CRA as far as this makes sense considering the technical circumstances - so, at first glance: No, it's favored to wait for CRA to provide this.

Yet ... there is support forscss/sass on thenext branch, i.e. it will be released with V2.0, so I'd say it's valid to somewhat "pre-pick" this as long as matches their implementation as far as feasible.

Which means that there are two changes to take care of:

  • The pattern should match for bothscss andsass files.
  • Remove thenode-sass resp.node-sass-chokidar dependency. The latter doesn't have any use here anyway, since its watcher is not used anyway. Regardingnode-sass, it seems to be favorable to let users install it in case they need this feature, esp. since it has a native dependency (libsass) - at least that was mentioned in some of the threads on CRA discussingsass support.
ianschmitz and valoricDe reacted with thumbs up emoji

@kmturleykmturley mentioned this pull requestAug 23, 2018
@kmturley
Copy link

I forked this repo and added sass-loader support:
kmturley@896190a

I pushed to npm as:
https://www.npmjs.com/package/react-scripts-scss-ts

Which means you can start apps using:
npx create-react-app react-typescript-scss-new --scripts-version=react-scripts-scss-ts

thefill and nartc reacted with thumbs up emoji

@nickserv
Copy link

This is fixed in CRA 2.

@cyril-lakech
Copy link

now CRA2 is here, what are the plan to use CRA2/SASS/TypeScript ?

@johnrom
Copy link

johnrom commentedSep 28, 2018
edited
Loading

Hi all,

I've created a fork merging@thefill 's changes with the latestcreate-react-app-typescript/master and changed the webpack configs to use the new CRA 2.0 method.

Unfortunately, either@thefill 's repository does not accept PRs or Github is bugging out, so if@thefill wants to PR my PR into his PR, that seems like the proper way to do this, otherwise I can PR this repository directly.

https://github.com/nimblelight/create-react-app-typescript/tree/thefill/master-2

@thefill
Copy link
Author

Hey@johnrom its github's issue I'm afraid - have no restrictions from my side ;-/ best if you can PR it directly if you be so kind ;-)

btw I abandoned those scripts completely with all its complex webpack configs... for last few weeks my team is using parcel & all is sooooooo much faster / better / easier. If anybody fancy I can create a quick&dirty public repo with a sample setup.

@johnrom
Copy link

ok, then this PR can be closed, I'll make a reference from my PR to here for documentation purposes.

I think my team will stick with thecreate-react-app method, maybe we'll revisit Parcel after we've had to eject and our lives have become more complicated.

thefill reacted with thumbs up emoji

@johnromjohnrom mentioned this pull requestOct 1, 2018
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@thefill@Bogala@clakech@DorianGrey@kmturley@nickserv@cyril-lakech@johnrom@fillaa

[8]ページ先頭

©2009-2025 Movatter.jp