- Notifications
You must be signed in to change notification settings - Fork488
Fix/improve end to end tests#326
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
patrick91 commentedMay 17, 2018
@DorianGrey the e2e tests are passing, even if I emptied the |
DorianGrey commentedMay 18, 2018
I already mentioned in the other PR that the The template is located here:https://github.com/wmonk/create-react-app-typescript/tree/master/packages/react-scripts/fixtures/kitchensink |
patrick91 commentedMay 19, 2018
Yup, it is using a different template for the application files, but it seems to be that it is still using the and here's the list of packages published on verdaccio: if I check the package.json of the created app we can also see that it is mentioning |
DorianGrey commentedMay 21, 2018
Yes - in the other PR, you already pointed out that the |
patrick91 commentedMay 21, 2018
So, this fix the test we should force the kitchensink to use |

Uh oh!
There was an error while loading.Please reload this page.
This PR will provide better e2e tests (so to actually check if TypeScript files are being loaded) and should also fix the failure with#270