Stick @types/node to 9.6.7 to avoid problems with 10.0.0#315

Merged

DorianGrey merged 1 commit intowmonk:masterfromDorianGrey:stick-node-types

May 2, 2018

Merged

Stick @types/node to 9.6.7 to avoid problems with 10.0.0#315

DorianGrey merged 1 commit intowmonk:masterfromDorianGrey:stick-node-types

May 2, 2018

Conversation

Copy link

Collaborator

DorianGrey commentedApr 27, 2018•
edited
Loading

@types/node 10.0.0 broke the travis build (again), since it causes collisions with typescripts own definitions. Stick with 9.6.7 for now will hopefully fix this...

Refers to:DefinitelyTyped/DefinitelyTyped#25342
Restriction should be retained until this issue gets resolved.

Stick @types/node to 9.6.7 to avoid problems with 10.0.0

5c9f4ce

Copy link

CollaboratorAuthor

DorianGrey commentedApr 27, 2018

Thekitchensink test is failing (again) due to a missingbabel-loader - still investigating what causes this problem...

Copy link

CollaboratorAuthor

DorianGrey commentedMay 2, 2018

I'll push this through for now, the CI problem seems unrelated, and I'm still investigating it.

DorianGrey merged commit10b727f intowmonk:master

May 2, 2018

sebald pushed a commit to sebald/create-react-app-typescript that referenced this pull request

May 8, 2018

Merge branch 'master' into allow-moduleNameMapper-override

25d06bb

* master:  Stick @types/node to 9.6.7 to avoid problems with 10.0.0 (wmonk#315)  Fix travis build (wmonk#302)  v2.15.1  Update README For 2.15.1  fix(modules): remove duplicate mjs from jest config

Copy link

Owner

wmonk commentedMay 10, 2018

@DorianGrey I think we should revert this before the next release - what do you think?

Copy link

CollaboratorAuthor

DorianGrey commentedMay 11, 2018•
edited
Loading

@wmonk - yes, I'll revert it (#321), Just added this since it wasn't predictable how a long a fix in the typings will take. Luckily, this didn't took long.