This repository was archived by the owner on Jan 26, 2019. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork488
Remove tslint-loader from prod build (again)#233
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
johnnyreilly commentedJan 22, 2018
Was just about to do exactly the same! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You do not need to remove these three lines starting with "TODO". As far as I can see, they are not related to the tslint-loader block. (Correct me if I am wrong.) I am pointing this out because webpack.config.dev.js still has these three lines. :)
CollaboratorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the hint - updated!
Owner
wmonk commentedJan 22, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ah whoops this was my fault |
wmonk approved these changesJan 22, 2018
0fedbfa tob40c8c5CompareOwner
wmonk commentedJan 22, 2018
Released in 2.13.0 |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just been notified that
tslint-loadersomehow made it into the production config again:#165 (comment)This one is not required due to the
fork-ts-checker.