This repository was archived by the owner on Jan 26, 2019. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork488
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add support for fork-ts-checker-webpack-plugin
Adjust 'Testing components' section to use the correct TS versions.
Add link to typescript User Guide
@types into devDependencies
OwnerAuthor
wmonk commentedJan 11, 2018
@DorianGrey also the plan is to reset the master branch to this branch. The merged upsteam is at#221 |
DorianGrey approved these changesJan 12, 2018
Collaborator
DorianGrey left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Rebasing sounds reasonable to get rid of the publish/unpublish part.
| importReactDOMfrom'react-dom'; | ||
| ```ts | ||
| import*asReactfrom'react'; | ||
| import*asReactDOMfrom'react-dom'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
space missing
OwnerAuthor
wmonk commentedJan 13, 2018
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
@DorianGrey i've spent some time creating the future 2.9.0 branch as its very annoying that master is unable to be published. I've picked all PRs that were merged into master after#183 was merged. Can you just sanity check this includes the correct changes. After this is merged i will create 2.10.0 with the 1.0.17 changes from facebook.