Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

CSS modules with Typings#197

Closed
tomaash wants to merge4 commits intowmonk:masterfromtomaash:master
Closed

Conversation

@tomaash
Copy link

No description provided.

@tomaashtomaash changed the titleinclude typings-for-css-modules-loaderCSS modules with TypingsNov 27, 2017
@DorianGrey
Copy link
Collaborator

@tomaash , don't get me wrong - I appreciate the effort you've put into this.
But I think this is a bit too specialized to include it by default, especially since users that don't want to use it still have to live with the overhead it creates, at least without ejecting their project.
Furthermore, weakening the type checking strictness is something I'd not recommend or like, at least if it can be avoided.

However, I would be really useful to have this setup available in some kind of documentation for those interested in it.

@tomaash
Copy link
Author

I agree, this cannot really be just merged. After some experimenting, I reverted my approach to not usetypings-for-css-modules-loader as well. The overhead is just too much. I'll create another PR with less intrusive approach when I get it more polished.

@tomaash
Copy link
Author

OK, so I just figured out that the best way to get CSS modules to any create-react-app setup is to usereact-app-rewired Now my addons to react-scripts webpack are in aplugin. Closing this PR.

@tomaashtomaash closed thisDec 6, 2017
@FDiskas
Copy link

FDiskas commentedMar 30, 2018
edited
Loading

@tomaash
create-react-app css modules enabled by default.
Try creating css file

:local {  .demo: {color: red; }}

then just import it like

importstylefrom'./my.css'//...<MyAppclassname={style.demo}/>

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomaash@DorianGrey@FDiskas

[8]ページ先頭

©2009-2025 Movatter.jp