This repository was archived by the owner on Jan 26, 2019. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork488
Include TypeScript as devDependency in boilerplate output#181
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Squiggle commentedJan 4, 2018
Can we expect this to be merged/released at any point soon? |
Owner
wmonk commentedJan 14, 2018
@ianschmitz could you update this to fix merge conflicts? |
ContributorAuthor
ianschmitz commentedJan 15, 2018
Yes I can. Won't be until end of week since I'm out of country. |
ContributorAuthor
ianschmitz commentedJan 19, 2018
Should be good to go now 👍 |
DorianGrey approved these changesJan 20, 2018
Collaborator
DorianGrey left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Owner
wmonk commentedJan 22, 2018
Released in 2.13.0 |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#85.
This will remove
typescriptfromreact-scripts-tsand instead include it as adevDependencyin the boilerplate output.Note that I have added it as a
peerDependencyinreact-scripts-ts. I think this is the right way to handle it, as users upgrading from 2.x ofreact-scripts-tswould see anUNMET PEER DEPENDENCYduring an install. However this means that when creating a new app the user will see this: