This repository was archived by the owner on Jan 26, 2019. It is now read-only.

wmonk/create-react-app-typescriptPublic archive

NotificationsYou must be signed in to change notification settings
Fork488
Star3.7k

Add support for fork-ts-checker-webpack-plugin #160#161

Closed

johnnyreilly wants to merge5 commits intowmonk:masterfromjohnnyreilly:master

Closed

Add support for fork-ts-checker-webpack-plugin #160#161

johnnyreilly wants to merge5 commits intowmonk:masterfromjohnnyreilly:master

Conversation

Copy link

johnnyreilly commentedSep 12, 2017•
edited
Loading

Relates to#160

Hello!

Since it seemed to be fairly easy to plug this in I thought I'd have a go. It seems to work. You may not want this PR and that's fine. But I had some free time and so here you go. ❤️

Following my changes, if I put a linting issue in the code:

console.log('bad right?')

Here's what I see in the browser:

If I put a compilation error in the code:

this_is_an_actual_error

I see this in the browser:

Oh - GitHub won't let me copy that in. Not sure why. Anyway, it says:

C:/work/my-app/src/App.tsx(24,1): Cannot find name 'this_is_an_actual_error'.

I wasn't sure exactly how you're supposed to test changes. I just created a react app using the existing mechanism, applied my changes over the top and then ran. There may be a "proper" way to test things. Happy to be instructed.

Add support for fork-ts-checker-webpack-plugin

baab09e

Copy link

Author

johnnyreilly commentedSep 12, 2017

I have no idea how I killed the test with my change.

Copy link

Collaborator

DorianGrey commentedSep 18, 2017

That's a curious error:

../react-dev-utils/node_modules/http-parser-js/package.json:1  1: {     ^ Unexpected end of input

Occurs onTEST_SUITE=simple on both node 6 and 8. Do these execute normally if you run them in your local environment?

Copy link

Author

johnnyreilly commentedSep 18, 2017

Weirdly runningnpm run build results in:

Cannot find "C:\source\create-react-app-typescript\packages\react-scripts\config\tsconfig.json" file. Please check webpack and ForkTsCheckerWebpackPlugin configuration.Possible errors:  - wrong `context` directory in webpack configuration (if `tsconfig` is not set or is a relative path in fork plugin configuration)  - wrong `tsconfig` path in fork plugin configuration (should be a relative or absolute path)

I'm afraid I don't know how this ought to be fixed...

Copy link

Owner

wmonk commentedSep 18, 2017

@johnnyreilly you can see the better error now - think before it was just a Travis issue - but I have rerun and now you can see the actual error being an issue with your change. You should rebase against master branch to get latest changes as well.

Copy link

Collaborator

DorianGrey commentedSep 18, 2017

@johnnyreilly :

I'm afraid I don't know how this ought to be fixed...

In the current version of the commit, the config forForkTsCheckerWebpackPlugin does not explicitly point to thetsconfig.json andtslint.json files. This might be a problem here, since the scripts are using several workarounds to support both ejected and non-ejected projects.
I'd suggest to explicitly list set the paths to the relevant config files and the directory to watch. You can use thepaths helper for this:
https://github.com/wmonk/create-react-app-typescript/blob/master/packages/react-scripts/config/paths.js

So the resulting plugin config might look like this.

new ForkTsCheckerWebpackPlugin({  checkSyntacticErrors: true,  async: false,  watch: paths.appSrc,  tsconfig: paths.appTsConfig,  tslint:  paths.appTsLint}),

paths.appTsLint is not defined yet - just add it as required, similar to the way the paths for thetsconfig have been added.