Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

add typechecking to tslint#140

Closed
GabrielCastro wants to merge1 commit intowmonk:masterfromGabrielCastro:add-type-check-to-tslint
Closed

add typechecking to tslint#140

GabrielCastro wants to merge1 commit intowmonk:masterfromGabrielCastro:add-type-check-to-tslint

Conversation

@GabrielCastro
Copy link

This solves#126,
I ran eject on a project made these changes and no longer get the flash error from tslint

dehbmarques, ianschmitz, nottoseethesun, kitos, tiagoefmoraes, and gullitmiranda reacted with thumbs up emojidalcib reacted with laugh emoji
@gsteacy
Copy link

I'm not sure type checking should be enabled while this is still an issue:wbuchwalter/tslint-loader#76. Even on small projects I noticed a performance hit of 250-300%.

@pelotom
Copy link
Contributor

pelotom commentedSep 26, 2017
edited
Loading

@gsteacy agreed, I've stopped usingtslint-loader and switched totslint-webpack-plugin because of this.

@stevenmusumeche
Copy link

@pelotom are you able to do that without ejecting though?

@pelotom
Copy link
Contributor

@stevenmusumeche no.

@wmonk
Copy link
Owner

As this issue hasn't been updated for a while, I am going to close it. If there are any updates feel free to re-open and comment. 👍

@wmonkwmonk closed thisJan 14, 2018
@DorianGrey
Copy link
Collaborator

FYI:fork-ts-checker-webpack-plugin, which was added in 2.10, supports linting rules that require type checking by sharingts.Program instances, so that feature should be available anyway.

@pelotom
Copy link
Contributor

Yes, however be aware thatfork-ts-checker-webpack-plugin hasa bug with theno-unused-variable rule which may or may not bite you. For my project it was intolerable; I had to disable the rule and use thetsc—noUnusedLocals flag instead.

@DorianGrey
Copy link
Collaborator

That's currently the case in the template -noUnusedLocals is used as a compiler option,no-unused-variable is not part of the linter config.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@stevenmusumechestevenmusumechestevenmusumeche approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GabrielCastro@gsteacy@pelotom@stevenmusumeche@wmonk@DorianGrey

[8]ページ先頭

©2009-2025 Movatter.jp