- Notifications
You must be signed in to change notification settings - Fork488
Update tsconfig to support dynamic import#115
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolaserny commentedJul 24, 2017
@wmonk using esnext seems to have an impact on tests (SyntaxError: Unexpected token import). |
nicolaserny commentedJul 24, 2017
@wmonk only a temporary fix (for jest) becauseTS_CONFIG is deprecated |
DorianGrey commentedJul 25, 2017
What about creating a I.e.: {"extends":"./tsconfig.json","compilerOptions": {"module":"commonjs" }}Add corresponding path entries inthis file, e.g. It's a bit tricky, but different
Using different config files for both situations should be the way to go here. |
DorianGrey left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@wmonk:
Change looks good technically. Your turn now :)
wmonk commentedJul 27, 2017
Thanks! |
resolves#90
In order to make code splitting work, we have to set the module to esnext in tsconfig.json