Commitc3e9e93

committed

feat(validations): guard "unstake-it-all" rule behind V2_1 guard

1 parent4a84eff commitc3e9e93Copy full SHA for c3e9e93

File tree

-5

lines changed

-5

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5189,7 +5189,7 @@ mod tests {`
`5189`	`5189`	`// Unstake all for validator 2`
`5190`	`5190`	`process_unstake_transactions(`
`5191`	`5191`	`&mut stakes,`
`5192`		`-[unstake_txn_1.clone()],`
	`5192`	`+[unstake_txn_1.clone()].iter(),`
`5193`	`5193`	`block_epoch,`
`5194`	`5194`	`10_000_000_000_000,`
`5195`	`5195`	`)`
`@@ -5254,7 +5254,7 @@ mod tests {`
`5254`	`5254`	`// Unstake all again for validator 2`
`5255`	`5255`	`process_unstake_transactions(`
`5256`	`5256`	`&mut stakes,`
`5257`		`-[unstake_txn_2],`
	`5257`	`+[unstake_txn_2].iter(),`
`5258`	`5258`	`block_epoch,`
`5259`	`5259`	`10_000_000_000_000,`
`5260`	`5260`	`)`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1465,7 +1465,9 @@ pub fn validate_unstake_transaction<'a>(`
`1465`	`1465`	`min_stake_nanowits:u64,`
`1466`	`1466`	`unstake_delay:u64,`
`1467`	`1467`	`) ->Result<(u64,u32,Vec<&'aValueTransferOutput>), anyhow::Error>{`
`1468`		`-ifget_protocol_version(Some(epoch)) <=ProtocolVersion::V1_8{`
	`1468`	`+let protocol_version =get_protocol_version(Some(epoch));`
	`1469`	`+`
	`1470`	`+if protocol_version <=ProtocolVersion::V1_8{`
`1469`	`1471`	`returnErr(TransactionError::NoUnstakeTransactionsAllowed.into());`
`1470`	`1472`	`}`
`1471`	`1473`
`@@ -1514,10 +1516,11 @@ pub fn validate_unstake_transaction<'a>(`
`1514`	`1516`	`.into());`
`1515`	`1517`	`}`
`1516`	`1518`	`};`
`1517`		`-`
	`1519`	`+`
	`1520`	`+// Introduced in V2_1:`
`1518`	`1521`	`// Apply a protocol-level "rule of convenience", where an amount to unstake of u64::MAX actually`
`1519`	`1522`	`// means "unstake all my stake".`
`1520`		`-if amount_to_unstake == u64::MAX{`
	`1523`	`+ifprotocol_version >=ProtocolVersion::V2_1 &&amount_to_unstake == u64::MAX{`
`1521`	`1524`	`amount_to_unstake = staked_amount;`
`1522`	`1525`	`}`
`1523`	`1526`

Comments

(0)