Commita99b906

committed

feat(validations): invert "unstake-it-all" logic

namely, use 0 instead of u64::MAX as the "unstake-it-all" meta-value

1 parentc3e9e93 commita99b906Copy full SHA for a99b906

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1520,7 +1520,9 @@ pub fn validate_unstake_transaction<'a>(`
`1520`	`1520`	`// Introduced in V2_1:`
`1521`	`1521`	`// Apply a protocol-level "rule of convenience", where an amount to unstake of u64::MAX actually`
`1522`	`1522`	`// means "unstake all my stake".`
`1523`		`-if protocol_version >=ProtocolVersion::V2_1 && amount_to_unstake == u64::MAX{`
	`1523`	`+// Please take note that this validation sctrictly needs to take place before checking whether`
	`1524`	`+// the "remainder" amount meets the minimum stake. Otherwise, we would never reach this block.`
	`1525`	`+if protocol_version >=ProtocolVersion::V2_1 && amount_to_unstake ==0{`
`1524`	`1526`	`amount_to_unstake = staked_amount;`
`1525`	`1527`	`}`
`1526`	`1528`

Comments

(0)