Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add channel access flow (WPB-15874)#3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ohassine merged 24 commits intodevelopfromadd-channel-access-flow
Mar 21, 2025

Conversation

ohassine
Copy link
Member

@ohassineohassine commentedMar 20, 2025•
edited by github-actionsbot
Loading

StoryWPB-15874 [Android] Start a new Channel - Create a new Channel

PR Submission Checklist for internal contributors

  • ThePR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number likeSQPIT-764
    • answers the question:If merged, this PR will: ... ³

  • ThePR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Adding the flow for changing access when we create a new channel.
For now, we don't support public, so it's disabled.

Screen_recording_20250320_162452.webm

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g.feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

# Conflicts:#app/src/main/kotlin/com/wire/android/ui/home/conversations/search/SearchUsersAndServicesScreen.kt#app/src/main/kotlin/com/wire/android/ui/home/newconversation/common/ContinueWithParticipantsCountButton.kt#app/src/main/kotlin/com/wire/android/ui/home/newconversation/groupsearch/NewGroupConversationSearchPeopleScreen.kt#app/src/main/kotlin/com/wire/android/ui/home/newconversation/search/NewConversationSearchPeopleScreen.kt#app/src/main/res/values/strings.xml
@pull-request-sizePull Request Size
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

…-flow# Conflicts:#app/src/main/kotlin/com/wire/android/ui/home/newconversation/NewConversationViewModel.kt#app/src/main/kotlin/com/wire/android/ui/home/newconversation/groupOptions/GroupOptionsScreen.kt#app/src/main/res/values/strings.xml#kalium
@github-actionsGitHub Actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

developThis PR
81201c6f12efcafe03827f3e78b7b5ed5fde1b3b5213401c6973bbd52eb29b71658bbb8ba511baa4

Is this intentional?

@github-actionsGitHub Actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

developThis PR
81201c6f12efcafe03827f3e78b7b5ed5fde1b3b5213401c6973bbd52eb29b71658bbb8ba511baa4

Is this intentional?

@ohassineohassine requested review froma team,typfel andalexandreferris and removed request fora teamMarch 20, 2025 16:55
@github-actionsGitHub Actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

developThis PR
81201c6f12efcafe03827f3e78b7b5ed5fde1b3b5213401c6973bbd52eb29b71658bbb8ba511baa4

Is this intentional?

@github-actionsGitHub Actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

developThis PR
81201c6f12efcafe03827f3e78b7b5ed5fde1b3b59d351417df671bcbca89b51aca7b7c8c8e9ed4e

Is this intentional?

@github-actionsGitHub Actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

developThis PR
81201c6f12efcafe03827f3e78b7b5ed5fde1b3b59d351417df671bcbca89b51aca7b7c8c8e9ed4e

Is this intentional?

@github-actionsGitHub Actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

developThis PR
81201c6f12efcafe03827f3e78b7b5ed5fde1b3bd84fdda83963cb2e4a50978d02d048b57b6777dc

Is this intentional?

@github-actionsGitHub Actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

developThis PR
81201c6f12efcafe03827f3e78b7b5ed5fde1b3bd84fdda83963cb2e4a50978d02d048b57b6777dc

Is this intentional?

@sonarqubecloudSonarQubeCloud
Copy link

@ohassineohassine added this pull request to themerge queueMar 21, 2025
@codecovCodecov
Copy link

codecovbot commentedMar 21, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is86.66667% with4 lines in your changes missing coverage. Please review.

Project coverage is 45.84%. Comparing base(2c18870) to head(6dc7b62).
Report is 1 commits behind head on develop.

Files with missing linesPatch %Lines
...i/home/newconversation/NewConversationViewModel.kt83.33%2 Missing and 2 partials⚠️
Additional details and impacted files
@@             Coverage Diff             @@##           develop    #3932      +/-   ##===========================================+ Coverage    45.78%   45.84%   +0.06%===========================================  Files          493      495       +2       Lines        17120    17143      +23       Branches      2854     2855       +1     ===========================================+ Hits          7838     7859      +21- Misses        8489     8491       +2  Partials       793      793
Files with missing linesCoverage Δ
...ns/details/options/GroupConversationOptionsItem.kt0.00% <ø> (ø)
...newconversation/channelaccess/ChannelAccessType.kt100.00% <100.00%> (ø)
...onversation/channelaccess/ChannelPermissionType.kt100.00% <100.00%> (ø)
...i/home/newconversation/NewConversationViewModel.kt70.07% <83.33%> (+2.57%)⬆️

Continue to review full report in Codecov by Sentry.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update2c18870...6dc7b62. Read thecomment docs.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue intodevelop with commit74d4c15Mar 21, 2025
14 of 15 checks passed
@ohassineohassine deleted the add-channel-access-flow branchMarch 21, 2025 16:30
@github-actionsGitHub Actions
Copy link
Contributor

Builtwire-android-staging-compat-pr-3932.apk is available for download

@github-actionsGitHub Actions
Copy link
Contributor

Builtwire-android-dev-debug-pr-3932.apk is available for download

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@MohamadJaaraMohamadJaaraMohamadJaara approved these changes

@vitorhugodsvitorhugodsvitorhugods approved these changes

@typfeltypfelAwaiting requested review from typfeltypfel was automatically assigned from wireapp/android

@alexandreferrisalexandreferrisAwaiting requested review from alexandreferrisalexandreferris was automatically assigned from wireapp/android

@GarzasGarzasAwaiting requested review from GarzasGarzas was automatically assigned from wireapp/android

@saleniuksaleniukAwaiting requested review from saleniuksaleniuk was automatically assigned from wireapp/android

@emmaoke-wemmaoke-wAwaiting requested review from emmaoke-wemmaoke-w was automatically assigned from wireapp/android

@yamilmedinayamilmedinaAwaiting requested review from yamilmedina

Assignees

@ohassineohassine

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ohassine@MohamadJaara@vitorhugods
[8]ページ先頭
©2009-2025 Movatter.jp