Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add query profiling and cached paginated list [WPB-14826]#3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuksaleniuk commentedDec 10, 2024
edited by github-actionsbot
Loading

BugWPB-14826 [Android] Conversation list loading very slow after closing a conversation


PR Submission Checklist for internal contributors

  • ThePR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number likeSQPIT-764
    • answers the question:If merged, this PR will: ... ³
  • ThePR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Paginated conversation list is loading slowly when navigating back from conversation screen.

Solutions

Implement caching for thePagingData flow - there's a ready to use extension functioncachedIn.
Add a logic to enable or disable database profiling to have logs with query execution times if the user enabled logging (only for cipher db) - thanks to that we will be able to confirm or eliminate some queries as potential causes of slow loading of conversation list.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Open conversation and navigate back - list should be cached and appear faster on the screen.
Enable logging in the app and check logcat or logs collected in the file to make sure there are also logs with query execution times.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g.feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hqechoes-hqbot added the echoes: unplannedAny work item that isn’t part of the product or technical roadmap. labelDec 10, 2024
@github-actionsGitHub Actions
Copy link
Contributor

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

developThis PR
26b7d4b4dcf2b50b64a3979e6211094a7a5d63d485de0cfb5906f5fbf5e9ce903f09b3edd92bc22d

Is this intentional?

@github-actionsGitHub Actions
Copy link
Contributor

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

developThis PR
26b7d4b4dcf2b50b64a3979e6211094a7a5d63d485de0cfb5906f5fbf5e9ce903f09b3edd92bc22d

Is this intentional?

@codecov-commenter
Copy link

codecov-commenter commentedDec 10, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is81.81818% with4 lines in your changes missing coverage. Please review.

Project coverage is 45.63%. Comparing base(a346709) to head(bec0301).
Report is 36 commits behind head on develop.

Files with missing linesPatch %Lines
...rc/main/kotlin/com/wire/android/WireApplication.kt0.00%3 Missing⚠️
...ome/conversationslist/ConversationListViewModel.kt66.66%0 Missing and 1 partial⚠️
Additional details and impacted files
@@             Coverage Diff             @@##           develop    #3726      +/-   ##===========================================+ Coverage    45.58%   45.63%   +0.05%===========================================  Files          476      477       +1       Lines        16113    16134      +21       Branches      2736     2736              ===========================================+ Hits          7345     7363      +18- Misses        8001     8004       +3  Partials       767      767
Files with missing linesCoverage Δ
...com/wire/android/debug/DatabaseProfilingManager.kt100.00% <100.00%> (ø)
...ome/conversationslist/ConversationListViewModel.kt33.46% <66.66%> (+0.53%)⬆️
...rc/main/kotlin/com/wire/android/WireApplication.kt0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatea346709...bec0301. Read thecomment docs.

@github-actionsGitHub Actions
Copy link
Contributor

Builtwire-android-staging-compat-pr-3726.apk is available for download

@github-actionsGitHub Actions
Copy link
Contributor

Builtwire-android-dev-debug-pr-3726.apk is available for download

@saleniuksaleniuk requested review froma team,typfel,yamilmedina,borichellow,MohamadJaara andmathias-niboulies and removed request fora teamDecember 11, 2024 09:12
@saleniuksaleniuk added this pull request to themerge queueDec 11, 2024
@github-actionsGitHub Actions
Copy link
Contributor

Builtwire-android-staging-compat-pr-3726.apk is available for download

@github-actionsGitHub Actions
Copy link
Contributor

Builtwire-android-dev-debug-pr-3726.apk is available for download

@github-merge-queuegithub-merge-queuebot removed this pull request from themerge queue due to no response for status checksDec 11, 2024
@saleniuksaleniuk added this pull request to themerge queueDec 12, 2024
@github-merge-queuegithub-merge-queuebot removed this pull request from themerge queue due to no response for status checksDec 12, 2024
@saleniuksaleniuk added this pull request to themerge queueDec 12, 2024
@github-merge-queuegithub-merge-queuebot removed this pull request from themerge queue due to failed status checksDec 12, 2024
@sonarqubecloudSonarQubeCloud
Copy link

@saleniuksaleniuk added this pull request to themerge queueDec 13, 2024
@github-actionsGitHub Actions
Copy link
Contributor

Builtwire-android-staging-compat-pr-3726.apk is available for download

@github-actionsGitHub Actions
Copy link
Contributor

Builtwire-android-dev-debug-pr-3726.apk is available for download

Merged via the queue intodevelop with commit375b8caDec 13, 2024
13 of 14 checks passed
@saleniuksaleniuk deleted the feat/add-query-profiling-and-cached-conv-list branchDecember 13, 2024 15:25
@echoes-hqechoes-hqbot added echoes: product-roadmap/bugWork contributing to resolve a bug not critical enough to have raised an incident. and removed echoes: unplannedAny work item that isn’t part of the product or technical roadmap. labelsJan 13, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@borichellowborichellowborichellow approved these changes

@vitorhugodsvitorhugodsvitorhugods approved these changes

@typfeltypfelAwaiting requested review from typfeltypfel was automatically assigned from wireapp/android

@yamilmedinayamilmedinaAwaiting requested review from yamilmedinayamilmedina was automatically assigned from wireapp/android

@MohamadJaaraMohamadJaaraAwaiting requested review from MohamadJaaraMohamadJaara was automatically assigned from wireapp/android

@mathias-nibouliesmathias-nibouliesAwaiting requested review from mathias-nibouliesmathias-niboulies was automatically assigned from wireapp/android

Assignees

@saleniuksaleniuk

Labels
echoes: product-roadmap/bugWork contributing to resolve a bug not critical enough to have raised an incident.size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@saleniuk@codecov-commenter@borichellow@vitorhugods

[8]ページ先頭

©2009-2025 Movatter.jp