Commitce135eb

authored and

jenkins-bot

committed

Set invisible labels on label-less buttons

Change-Id: I688c93070be2e5674ce26f6160837aa0bb7e5f7b

1 parentf7a9486 commitce135ebCopy full SHA for ce135eb

File tree

+12

-3

lines changed

+12

-3

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,8 @@ ve.ui.AnnotationContextItem = function VeUiAnnotationContextItem( context, model`
`35`	`35`	`}else{`
`36`	`36`	`this.clearButton=newOO.ui.ButtonWidget({`
`37`	`37`	`title:this.constructor.static.clearMsg,`
	`38`	`+label:this.constructor.static.clearMsg,`
	`39`	`+invisibleLabel:true,`
`38`	`40`	`icon:this.constructor.static.clearIcon,`
`39`	`41`	`flags:['destructive']`
`40`	`42`	`});`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -65,12 +65,16 @@ ve.ui.FindAndReplaceDialog.prototype.initialize = function () {`
`65`	`65`	`icon:'previous',`
`66`	`66`	`title:ve.msg('visualeditor-find-and-replace-previous-button')+' '+`
`67`	`67`	`ve.ui.triggerRegistry.getMessages('findPrevious').join(', '),`
	`68`	`+label:ve.msg('visualeditor-find-and-replace-previous-button'),`
	`69`	`+invisibleLabel:true,`
`68`	`70`	`tabIndex:2`
`69`	`71`	`});`
`70`	`72`	`this.nextButton=newOO.ui.ButtonWidget({`
`71`	`73`	`icon:'next',`
`72`	`74`	`title:ve.msg('visualeditor-find-and-replace-next-button')+' '+`
`73`	`75`	`ve.ui.triggerRegistry.getMessages('findNext').join(', '),`
	`76`	`+label:ve.msg('visualeditor-find-and-replace-next-button'),`
	`77`	`+invisibleLabel:true,`
`74`	`78`	`tabIndex:2`
`75`	`79`	`});`
`76`	`80`	`this.matchCaseToggle=newOO.ui.ToggleButtonWidget({`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,9 @@ ve.ui.ProgressDialog.prototype.getSetupProcess = function ( data = {} ) {`
`89`	`89`	`constcancelButton=newOO.ui.ButtonWidget({`
`90`	`90`	`framed:false,`
`91`	`91`	`icon:'cancel',`
`92`		`-title:OO.ui.deferMsg('visualeditor-dialog-action-cancel')`
	`92`	`+title:OO.ui.deferMsg('visualeditor-dialog-action-cancel'),`
	`93`	`+label:OO.ui.deferMsg('visualeditor-dialog-action-cancel'),`
	`94`	`+invisibleLabel:true`
`93`	`95`	`}).on('click',cancelDeferred.reject.bind(cancelDeferred));`
`94`	`96`	`$row.append(cancelButton.$element);`
`95`	`97`	`cancellable=true;`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -36,9 +36,10 @@ ve.ui.LanguageInputWidget = function VeUiLanguageInputWidget( config = {} ) {`
`36`	`36`
`37`	`37`	`this.findLanguageButton=newOO.ui.ButtonWidget({`
`38`	`38`	`classes:['ve-ui-languageInputWidget-findLanguageButton'],`
`39`		`-icon:'ellipsis'`
	`39`	`+icon:'ellipsis',`
	`40`	`+label:ve.msg('visualeditor-dialog-language-search-title'),`
	`41`	`+invisibleLabel:true`
`40`	`42`	`});`
`41`		`-this.findLanguageButton.$button.attr('aria-label',ve.msg('visualeditor-dialog-language-search-title'));`
`42`	`43`	`this.selectedLanguageLabel=newOO.ui.LabelWidget({`
`43`	`44`	`classes:['ve-ui-languageInputWidget-selectedLanguageLabel'],`
`44`	`45`	`label:ve.msg('visualeditor-languageinspector-widget-changelang')`

Comments

(0)