Commitb3d3b8b

authored

fix: Stop multiple buttons from compounding in the workspace action dropdown (coder#3482)

The variadic function on an object doesn't clone the inner array.This was causing the `secondary` property to accumulate more andmore button types as time went on!Fixescoder#3154.

1 parent16c12e9 commitb3d3b8bCopy full SHA for b3d3b8b

File tree

1 file changed

-1

lines changed

site/src/components/WorkspaceActions
- WorkspaceActions.tsx

1 file changed

-1

lines changed

`‎site/src/components/WorkspaceActions/WorkspaceActions.tsx`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ export const WorkspaceActions: FC<WorkspaceActionsProps> = ({`
`68`	`68`	`// if an update is available, we make the update button the primary CTA`
`69`	`69`	`// and move the former primary CTA to the secondary actions list`
`70`	`70`	`constupdatedActions={ ...WorkspaceStateActions[workspaceState]}`
`71`		`-updatedActions.secondary.unshift(updatedActions.primary)`
	`71`	`+updatedActions.secondary=[updatedActions.primary, ...updatedActions.secondary]`
`72`	`72`	`updatedActions.primary=ButtonTypesEnum.update`
`73`	`73`
`74`	`74`	`returnupdatedActions`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb3d3b8b

File tree

1 file changed

1 file changed

`‎site/src/components/WorkspaceActions/WorkspaceActions.tsx`

0 commit comments