Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

The WebSocketStream Interface#48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ricea wants to merge33 commits intomain
base:main
Choose a base branch
Loading
fromadd-websocketstream
Open
Changes from1 commit
Commits
Show all changes
33 commits
Select commitHold shift + click to select a range
579e413
[WIP] The WebSocketStream Interface
riceaNov 11, 2021
3c4803b
Fix grammatical errors
riceaJan 23, 2024
8e5f06b
Note that backpressure is obeyed for writable
riceaJan 23, 2024
5cb355b
Remove mention of passing close code or reason to abort() or cancel()
riceaJan 23, 2024
1f9a2d6
Revert "Remove mention of passing close code or reason to abort() or …
riceaJan 28, 2024
96baeed
Mention that it has to be a WebSocketError
riceaJan 28, 2024
69bae4f
Add IDL for WebSocketError
riceaJan 28, 2024
fa5ff83
Add algorithm steps for WebSocketStream and WebSocketError
riceaJan 28, 2024
adf4bbe
Changes from reviews
riceaJan 30, 2024
f488ee4
Add missing AbortSignal algorithm steps.
riceaJan 30, 2024
b1a58f4
Use Bikeshed magic to get a URL record
riceaJan 31, 2024
8cc184c
Add missing colon
riceaJan 31, 2024
7812163
Remove "the user agent must run..."
riceaJan 31, 2024
47ab0da
Fix capitalisation of "close"
riceaJan 31, 2024
2b9ee80
Server can't send a bad reason, and wording improvement (by @domenic)
riceaJan 31, 2024
12ff404
Editorial changes from @domenic. Also change `closeCode` to [EnforceR…
riceaJan 31, 2024
a2fc7c2
Change `|this|` to `[=this=]` everywhere
riceaJan 31, 2024
3a285c7
Fix initialization of dictionaries and WebSocketErrors
riceaJan 31, 2024
397dd00
Demote "Feedback from the protocol" and "The CloseEvent interface"
riceaJan 31, 2024
9e8d8f7
Indent "Garbage Collection" and fix the WebSocketStream interface ena…
riceaFeb 1, 2024
673ace9
Use "queue a global task"
riceaFeb 6, 2024
30f5f8b
Explicitly say what realm write algorithm's promise is created in
riceaFeb 6, 2024
7d85772
Add more <hr>s
riceaFeb 6, 2024
1d7d868
Place The WebSocket Protocol in <cite> tags
riceaFeb 6, 2024
7b81f79
Fix many small nits from domenic@'s review
riceaFeb 6, 2024
6da74e7
Add a missing comma
riceaFeb 21, 2024
16a75fe
Fix description of "was ever connected"
riceaFeb 21, 2024
2bd7ad5
Fix grammar in developer notes
riceaFeb 21, 2024
b2e001c
Apply cleanups by @domenic.
riceaFeb 21, 2024
1e2eae9
Fixes requested by @domenic
riceaFeb 21, 2024
24f24f8
Fix Bikeshed compile error
riceaFeb 21, 2024
a6d426f
Set defaults for WebSocketError's closeCode and reason
riceaFeb 21, 2024
d5570f3
Add default arguments
riceaMar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Add missing AbortSignal algorithm steps.
Also apply backpressure on connection, and linkify "exists".
  • Loading branch information
@ricea
ricea committedJan 30, 2024
commitf488ee44e962f569b1e42855ea9c4edb3f1bcecd
29 changes: 25 additions & 4 deletionsindex.bs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -796,6 +796,9 @@ which is a {{WritableStream}}.
Each {{WebSocketStream}} object has an associated <dfn for="WebSocketStream">was ever connected
flag</dfn>, which is initially unset.

Each {{WebSocketStream}} object has an associated <dfn for="WebSocketStream">handshake aborted
flag</dfn>, which is initially unset.

Each {{WebSocketStream}} object has an associated <dfn for="WebSocketStream">ready state</dfn>,
which is a number representing the state of the connection. Initially it must be
{{WebSocket/CONNECTING}} (0). It has the same semantics as {{WebSocket}}'s [=WebSocket/ready
Expand DownExpand Up@@ -895,15 +898,30 @@ state=], but is not exposed to JavaScript.
1. Let |baseURL| be [=this=]'s [=relevant settings object=]'s [=API base URL=].
1. Let |urlRecord| be the result of [=get a URL record|getting a URL record=] given |url| and
|baseURL|.
1. Let |protocols| be |options|["{{WebSocketStreamOptions/protocols}}"] if it exists, otherwise an
empty sequence.
1. Let |protocols| be |options|["{{WebSocketStreamOptions/protocols}}"] if it[=map/exists=],
otherwise anempty sequence.
1. If any of the values in |protocols| occur more than once or otherwise fail to match the
requirements for elements that comprise the value of
\`<a http-header>`Sec-WebSocket-Protocol`</a>\` fields as defined by The WebSocket protocol,
then throw a "{{SyntaxError}}" {{DOMException}}. [[!WSP]]
1. Set [=this=]'s [=WebSocketStream/url=] to |urlRecord|.
1. Set [=this=]'s [=WebSocketStream/opened promise=] and [=WebSocketStream/closed promise=] to new
promises.
1. Apply backpressure to the WebSocket.

Note: This means that messages won't be read until the application is ready for them.

1. If |options|["{{WebSocketStreamOptions/signal}}"] [=map/exists=],
1. Let |signal| be |options|["{{WebSocketStreamOptions/signal}}"].
1. If |signal| is [=AbortSignal/aborted=], then reject [=this=]'s [=WebSocketStream/opened
promise=] and [=WebSocketStream/closed promise=] with |signal|'s [=abort reason=] and return.
1. [=AbortSignal/add|Add the following abort steps=] to |signal|:
1. If the WebSocket connection is not yet [=established=] [[!WSP]]
1. [=Fail the WebSocket connection=] and set [=this=]'s [=WebSocketStream/ready state=] to
{{WebSocket/CLOSING}}.
1. [=Reject=] [=this=]'s [=WebSocketStream/opened promise=] and [=WebSocketStream/closed
promise=] with |signal|'s [=abort reason=].
1. Set [=this=]'s [=WebSocketStream/handshake aborted flag=].
1. Let |client| be [=this=]'s [=relevant settings object=].
1. Run this step [=in parallel=]:
1. [=Establish a WebSocket connection=] given |urlRecord|, |protocols|, and |client|. [[!FETCH]]
Expand DownExpand Up@@ -1008,6 +1026,7 @@ When [=the WebSocket connection is closed=] for a {{WebSocketStream}} |stream|,
[=cleanly=], the user agent must [=queue a task=] to run the following substeps:

1. Change the [=WebSocketStream/ready state=] to {{WebSocket/CLOSED}} (3).
1. If |stream|'s [=WebSocketStream/handshake aborted flag=] is set, then return.
1. If |stream|'s [=WebSocketStream/was ever connected flag=] is not set, then [=reject=] |stream|'s
[=opened promise=] with a [=new=] WebSocketError.
1. Let |code| be [=the WebSocket connection close code=].
Expand DownExpand Up@@ -1174,8 +1193,10 @@ WebSocketError(|message|, |init|)</code></dfn> constructor steps are:

1. Set |this|'s [=DOMException/name=] to "<code>WebSocketError</code>".
1. Set |this|'s [=DOMException/message=] to |message|.
1. Let |code| be |init|["{{WebSocketCloseInfo/closeCode}}"] if it exists, or unset otherwise.
1. Let |reason| be |init|["{{WebSocketCloseInfo/reason}}"] if it exists, or unset otherwise.
1. Let |code| be |init|["{{WebSocketCloseInfo/closeCode}}"] if it [=map/exists=], or unset
otherwise.
1. Let |reason| be |init|["{{WebSocketCloseInfo/reason}}"] if it [=map/exists=], or unset
otherwise.
1. [=Validate close code and reason=] with |code| and |reason|.
1. If |reason| is non-empty, but |code| is not set, then set |code| to 1000 ("Normal Closure").
1. Set |this|'s [=WebSocketError/closeCode=] to |code|.
Expand Down
[8]ページ先頭
©2009-2025 Movatter.jp