- Notifications
You must be signed in to change notification settings - Fork18
The WebSocketStream Interface#48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ricea wants to merge33 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
33 commits Select commitHold shift + click to select a range
579e413 [WIP] The WebSocketStream Interface
ricea3c4803b Fix grammatical errors
ricea8e5f06b Note that backpressure is obeyed for writable
ricea5cb355b Remove mention of passing close code or reason to abort() or cancel()
ricea1f9a2d6 Revert "Remove mention of passing close code or reason to abort() or …
ricea96baeed Mention that it has to be a WebSocketError
ricea69bae4f Add IDL for WebSocketError
riceafa5ff83 Add algorithm steps for WebSocketStream and WebSocketError
riceaadf4bbe Changes from reviews
riceaf488ee4 Add missing AbortSignal algorithm steps.
riceab1a58f4 Use Bikeshed magic to get a URL record
ricea8cc184c Add missing colon
ricea7812163 Remove "the user agent must run..."
ricea47ab0da Fix capitalisation of "close"
ricea2b9ee80 Server can't send a bad reason, and wording improvement (by @domenic)
ricea12ff404 Editorial changes from @domenic. Also change `closeCode` to [EnforceR…
riceaa2fc7c2 Change `|this|` to `[=this=]` everywhere
ricea3a285c7 Fix initialization of dictionaries and WebSocketErrors
ricea397dd00 Demote "Feedback from the protocol" and "The CloseEvent interface"
ricea9e8d8f7 Indent "Garbage Collection" and fix the WebSocketStream interface ena…
ricea673ace9 Use "queue a global task"
ricea30f5f8b Explicitly say what realm write algorithm's promise is created in
ricea7d85772 Add more <hr>s
ricea1d7d868 Place The WebSocket Protocol in <cite> tags
ricea7b81f79 Fix many small nits from domenic@'s review
ricea6da74e7 Add a missing comma
ricea16a75fe Fix description of "was ever connected"
ricea2bd7ad5 Fix grammar in developer notes
riceab2e001c Apply cleanups by @domenic.
ricea1e2eae9 Fixes requested by @domenic
ricea24f24f8 Fix Bikeshed compile error
riceaa6d426f Set defaults for WebSocketError's closeCode and reason
ricead5570f3 Add default arguments
riceaFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Note that backpressure is obeyed for writable
Temporarily force-link "writable stream writer" until it can be exportedfrom the streams standard.
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit8e5f06b9d13d255e1da324b212c2f77208985bb8
There are no files selected for viewing
7 changes: 6 additions & 1 deletionindex.bs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -34,6 +34,8 @@ spec:html; type:dfn; | ||
| spec:url; type:dfn; | ||
| text:origin | ||
| for:/; text:url | ||
| spec:streams; type:dfn | ||
| text:writable stream writer | ||
ricea marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| </pre> | ||
| <pre class=anchors> | ||
| @@ -886,7 +888,10 @@ initially unset. | ||
| : {{WebSocketOpenInfo/writable}} | ||
| :: A {{WritableStream}} that can be used to send messages to the server. Each chunk written will | ||
| be converted to one message. Strings will be sent as text messages; {{BufferSource}} chunks will | ||
| be sent as binary messages. Backpressure due to the network or server being behind will | ||
ricea marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| automatically be observed by piping. When using a [=writable stream writer=], waiting for the | ||
| {{WritableStreamDefaultWriter/ready|writer.ready}} promise will ensure that backpressure is | ||
| obeyed. | ||
| The WebSocket can be closed by calling {{WritableStream/close()}} on | ||
| {{WebSocketOpenInfo/writable}}. | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.