- Notifications
You must be signed in to change notification settings - Fork2.9k
[WebDriver BiDi] report download complete / canceled#11289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Addressing [Access downloaded file content · Issue#894 · w3c/webdriver-bidi](#894).The "WebDriver BiDi download end" hook is to be engaged in HTML spec [[WebDriver BiDi] report download complete / failed / canceled by sadym-chromium · Pull Request #11289 · whatwg/html](whatwg/html#11289)
7542b32
tofa63b44
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please address TODO's in the description
</li> | ||
<li> | ||
<p>When the file downloading successfully completed:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I am not sure if these steps "if the file downloading was canceled by user or by the user agent, or if the file downloading faced any problems" and "When the file downloading successfully completed" are specific enough and also they define steps that do not happen in the order of the algorithm but I will defer to the HTML spec reviewers on this.
Uh oh!
There was an error while loading.Please reload this page.
Add a hook for reporting file download ended (complete or canceled) and provide the downloaded file path there. Required for WebDriver BiDi
browsingContext.downloadEnd
event.Refactoring
In order to provide the proper events' order, the "WebDriver BiDi download started" hook was moved into "handle as a download".
TODO: check if the
<var>navigable</var>
and<var>navigationId</var>
really can be null there.Specification
As long as the download processing is non-normative, the generic description was used:
browsingContext.downloadEnd
event web-platform-tests/wpt#52932browsingContext.downloadEnd
event w3c/webdriver-bidi#923browsingContext.downloadFinished
event GoogleChromeLabs/chromium-bidi#3427(SeeWHATWG Working Mode: Changes for more details.)