Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebDriver BiDi] report download complete / canceled#11289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
sadym-chromium wants to merge6 commits intowhatwg:main
base:main
Choose a base branch
Loading
fromsadym-chromium:sadym/download-status

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromiumsadym-chromium commentedMay 7, 2025
edited
Loading

Add a hook for reporting file download ended (complete or canceled) and provide the downloaded file path there. Required for WebDriver BiDibrowsingContext.downloadEnd event.

Refactoring

In order to provide the proper events' order, the "WebDriver BiDi download started" hook was moved into "handle as a download".
TODO: check if the<var>navigable</var> and<var>navigationId</var> really can be null there.

Specification

As long as the download processing is non-normative, the generic description was used:

  • "If the file downloading was canceled by user or by the user agent"
  • "If the file downloading faced any problems"
  • "When the file downloading successfully completed"
  • At least two implementers are interested (and none opposed):
  • Chromium
  • Mozilla

(SeeWHATWG Working Mode: Changes for more details.)

@sadym-chromiumsadym-chromium changed the title[WebDriver BiDi] report download complete / failed / canceled[DRAFT][WebDriver BiDi] report download complete / failed / canceledMay 14, 2025
@sadym-chromiumsadym-chromium changed the title[DRAFT][WebDriver BiDi] report download complete / failed / canceled[DRAFT][WebDriver BiDi] report download complete / canceledMay 19, 2025
sadym-chromium added a commit to w3c/webdriver-bidi that referenced this pull requestJun 3, 2025
Addressing [Access downloaded file content · Issue#894 · w3c/webdriver-bidi](#894).The "WebDriver BiDi download end" hook is to be engaged in HTML spec [[WebDriver BiDi] report download complete / failed / canceled by sadym-chromium · Pull Request #11289 · whatwg/html](whatwg/html#11289)
@sadym-chromiumsadym-chromium changed the title[DRAFT][WebDriver BiDi] report download complete / canceled[WebDriver BiDi] report download complete / canceledJun 25, 2025
Copy link
Contributor

@OrKoNOrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please address TODO's in the description

</li>

<li>
<p>When the file downloading successfully completed:</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am not sure if these steps "if the file downloading was canceled by user or by the user agent, or if the file downloading faced any problems" and "When the file downloading successfully completed" are specific enough and also they define steps that do not happen in the order of the algorithm but I will defer to the HTML spec reviewers on this.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OrKoNOrKoNOrKoN left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sadym-chromium@OrKoN

[8]ページ先頭

©2009-2025 Movatter.jp