Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: friendship source#2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
suhli wants to merge4 commits intowechaty:main
base:main
Choose a base branch
Loading
fromsuhli:master
Draft

feat: friendship source#2120

suhli wants to merge4 commits intowechaty:mainfromsuhli:master

Conversation

@suhli
Copy link

Checklist

  • Commit Messages follow theConventional Commits pattern
    • A feature commit message is prefixed "feat:"
  • Tests for the changes have been added
  • CI has been passed. (GitHub actions all turns green)
  • SLA has been signed

Description

please describe the changes that you are making, with the related issue number.

feature:Issues#1801 Friendship 里增加 申请好友的”来源“

ref:
wechaty-puppet Pull Request#127

:FriendshipType.Unknown
}

publicsource():FriendshipSource|null{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This new API name looks good.

Can we also think about this API a little bit future: what if we are using a Whatsapp puppet, or a WXWork/DingTalk/Lark puppet?

Does theFriendSource return type can also fulfill those IM platform requirements?

suhli reacted with thumbs up emoji
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ok i know your means

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@huanhuanhuan left review comments

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suhli@huan
[8]ページ先頭
©2009-2025 Movatter.jp