Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bug: add failing test for hashSalt in prod mode (realContentHash)#778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
wejendorp wants to merge1 commit intowebpack-contrib:master
base:master
Choose a base branch
Loading
fromwejendorp:hash-salt-bug

Conversation

wejendorp
Copy link

@wejendorpwejendorp commentedJun 30, 2021•
edited
Loading

This PR contains a:

  • bugfix
  • newfeature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

We noticed a bug with our bundles after adding salt values to the build.

Setting output.hashSalt together with optimization.realContentHash (e.g. prod mode)
results in wrong urls for asset-modules, resulting in broken bundles.

The added test seems to be minimum to reproduce. For context (sanity check), the naming issue
does not happen if the asset module is referenced from a js module instead.

Breaking Changes

None

Additional Info

This PR is just a bug report in the form of a failing test. I hope it can be useful to someone.

Setting output.hashSalt together with optimization.realContentHash (e.g. prod mode)results in wrong urls for asset-modules, resulting in broken bundles.Added test seems to be minimum to reproduce.
@codecov
Copy link

codecovbot commentedJul 1, 2021•
edited
Loading

Codecov Report

Merging#778 (b506919) intomaster (794b602) willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master     #778   +/-   ##=======================================  Coverage   92.04%   92.04%           =======================================  Files           6        6             Lines         704      704             Branches      170      170           =======================================  Hits          648      648             Misses         53       53             Partials        3        3

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update794b602...b506919. Read thecomment docs.

@alexander-akait
Copy link
Member

@wejendorp what is mini-css-extract-version?

@alexander-akait
Copy link
Member

Yep, bug, we will try to fix it in near future

@wejendorp
Copy link
Author

Yep, bug, we will try to fix it in near future

Thank you for verifying@alexander-akait, let me know if I can help or anything.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@wejendorp@alexander-akait
[8]ページ先頭
©2009-2025 Movatter.jp