Codecov Report

Merging#720 (b92fbe2) intomaster (6ae4c3e) willdecrease coverage by19.24%.
The diff coverage is100.00%.

@@             Coverage Diff             @@##           master     #720       +/-   ##===========================================- Coverage   89.67%   70.43%   -19.25%===========================================  Files           6        6                 Lines         775      778        +3       Branches      239      240        +1     ===========================================- Hits          695      548      -147- Misses         77      212      +135- Partials        3       18       +15

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update6ae4c3e...b92fbe2. Read thecomment docs.

arg, why is trying to upgrade a single dependency breaking everything!

codecov you don't make any sense.

hm, I don't think it is good idea to do in pitch phase, we can faced with infinity loop...

you'd certainly know better than me. Itseemed ok to me since the original request included it. What's happening is that the original module (withmatchResource) is sort of being ignored, since mini-extract and style-loader force a new module to be created, this time without the matchResource (since it's not in the request anymore)

I had also thought that the!!./loaders might prevent a loop since there is no resource matching for loaders?

I don't think we should touchmatchResource in pitch mode here, I think you need do on own side usingpitch, so I want to look how you do it right now

the simplest case is the base4-loader. which doesn't work with style-loader or mini-extract.

The way more complicate case is here, still a WIP.

https://github.com/4Catalyzer/astroturf/blob/f723dc2d23ece81417f34daf1d6562dba6f1fc15/src/inline-loader.ts

FYI this does seem to work if i manually setmatchResource on the module, but that seems like a bad idea?