Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork388
feat: add stats option#537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Expose a stats option to make hot module replacement and otherinformational messages optional. Only stat presets are supported but theAPI can be expanded to an object later if useful.
So far as I can tell, these errors are false positives due to preexisting security audit failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No need, webpack has built-in logger we should migrate on it
Thank you for the fast feedback,@evilebottnawi! I'm sorry but I didn't quite understand the feedback. Are you saying to use theWebpack logger API, to abandon this change, or something else? Thank you! |
Yes webpack logger API |
niedzielski commentedJun 12, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@evilebottnawi, done (I think). Edit: I tried to mimic thewebpack-dev-server implementation andoptions as the HMR client context is very similar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should use built-in webpack logger, notloglever
webpack-dev-server@4 migrate on built-in webpack logger |
@evilebottnawi, thank you. Isthis a good example to base the approach on? |
This PR contains a:
Motivation / Use-Case
Expose a stats option to make hot module replacement and other
informational messages optional. Only stat presets are supported but the
API can be expanded to an object later if useful.
Breaking Changes
Additional Info