Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: new hook miniCssExtractPluginBeforeLinkAppend#514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
hou-pu wants to merge3 commits intowebpack-contrib:master
base:master
Choose a base branch
Loading
fromhou-pu:master

Conversation

hou-pu
Copy link

@hou-puhou-pu commentedMar 22, 2020•
edited
Loading

Allow the link tag to be added to the head before doing some extra processing, such as I want to set a load timeout listener

This PR contains a:

  • bugfix
  • newfeature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

As the link loads, I want to add code that controls the timeout

Breaking Changes

No

Additional Info

Allow the link tag to be added to the head before doing some extra processing, such as I want to set a load timeout listener
@jsf-clabot
Copy link

jsf-clabot commentedMar 22, 2020•
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexander-akaitalexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We need tests for it

@ankurbigcomm
Copy link

@wangzongxu Any update on this. This might be critical for one of our applications as well.

@codecov
Copy link

codecovbot commentedAug 5, 2020•
edited
Loading

Codecov Report

Merging#514 (1c778c7) intomaster (b146549) willincrease coverage by0.05%.
The diff coverage is100.00%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #514      +/-   ##==========================================+ Coverage   88.55%   88.60%   +0.05%==========================================  Files           5        5                Lines         428      430       +2       Branches       96       96              ==========================================+ Hits          379      381       +2  Misses         47       47                Partials        2        2
Impacted FilesCoverage Δ
src/index.js87.96% <100.00%> (+0.11%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb146549...1c778c7. Read thecomment docs.

@hou-pu
Copy link
Author

Sorry

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alexander-akaitalexander-akaitalexander-akait requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@hou-pu@jsf-clabot@ankurbigcomm@alexander-akait
[8]ページ先頭
©2009-2025 Movatter.jp