webpack-contrib/mini-css-extract-pluginPublic

NotificationsYou must be signed in to change notification settings
Fork388
Star4.7k

feat: add beforeTagInsert hook#1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

alexander-akait merged 1 commit intowebpack-contrib:masterfrommsidolphin:master

Jan 31, 2024

Merged

feat: add beforeTagInsert hook#1054

alexander-akait merged 1 commit intowebpack-contrib:masterfrommsidolphin:master

Jan 31, 2024

Conversation

Copy link

Contributor

msidolphin commentedOct 7, 2023•
edited
Loading

This PR contains a:

bugfix
newfeature
code refactor
test update
typo fix
metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

When I tried webpack-subresource-integrity to inject integrities, I found that I couldn't add integrities to the style files if I also used mini-css-extract-plugin. due to the lack of hooks in mini-css-extract-plugin. Due to the lack of hooks in mini-css-extract-plugin, it is not possible to add additional attributes to the link tag.

Related issue

#40

Usage

importMiniCssExtractPluginfrom'mini-css-extract-plugin'MiniCssExtractPlugin.getHooks(compiler).beforeTagInsert.tap("YourPluginName",(source,varNames)=>compiler.webpack.Template.asString([source,`${varNames.tag}.setAttribute("integrity",  __webpack_require__.sriHashes[${varNames.chunkId}]);`,]));

Copy link

linux-foundation-easyclabot commentedOct 7, 2023•
edited
Loading

The committers listed above are authorized under a signed CLA.

✅ login: msidolphin / name: msidolphin (e295cc5)

msidolphin mentioned this pull request

Oct 12, 2023

Fix the same chunkId is overwritten after using mini-css-extract-pluginwaysact/webpack-subresource-integrity#225

Open

alexander-akait reviewed

Jan 24, 2024

View reviewed changes

src/hooks.jsShow resolvedHide resolved

alexander-akait reviewed

Jan 24, 2024

View reviewed changes

src/index.js OutdatedShow resolvedHide resolved

Copy link

Member

alexander-akait commentedJan 24, 2024

@msidolphin Also can you rebase, sorry for delay

Copy link

ContributorAuthor

msidolphin commentedJan 25, 2024

@msidolphin Also can you rebase, sorry for delay

The generated version of package-lock is too old, should I update it?

Copy link

Member

alexander-akait commentedJan 26, 2024

@msidolphin Just rebase

msidolphin force-pushed themaster branch fromb86ed75 toe7aac21Compare

January 29, 2024 08:01

msidolphin requested a review fromalexander-akait

January 29, 2024 08:02

Copy link

ContributorAuthor

msidolphin commentedJan 29, 2024

@msidolphin Just rebase

Okay, I'm done.

msidolphin force-pushed themaster branch 3 times, most recently fromc4c6601 to86cc2beCompare

January 31, 2024 03:25

feat: add beforeTagInsert hook

e295cc5

msidolphin force-pushed themaster branch from86cc2be toe295cc5Compare

January 31, 2024 03:27

alexander-akait approved these changes

Jan 31, 2024

View reviewed changes

Copy link

Member

alexander-akait commentedJan 31, 2024

Thank you, I will do release after#1057

Copy link

codecovbot commentedJan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(e3f8375) 90.40% compared to head(e295cc5) 90.31%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@##           master    #1054      +/-   ##==========================================- Coverage   90.40%   90.31%   -0.09%==========================================  Files           5        6       +1       Lines         875      888      +13       Branches      256      259       +3     ==========================================+ Hits          791      802      +11- Misses         74       76       +2  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.