webpack-contrib/mini-css-extract-pluginPublic

NotificationsYou must be signed in to change notification settings
Fork388
Star4.7k

add ';'to module.media#1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

alexander-akait merged 1 commit intowebpack-contrib:masterfromFi2zz:master

Jan 9, 2024

Merged

add ';'to module.media#1051

alexander-akait merged 1 commit intowebpack-contrib:masterfromFi2zz:master

Jan 9, 2024

Conversation

Copy link

Contributor

Fi2zz commentedSep 11, 2023•
edited
Loading

This PR contains a:

bugfix
newfeature
code refactor
test update
typo fix
metadata update

Use-Case

Giving css with at-rule-import

@import"https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css" screenand (min-width:640px);@import"https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css";div{color:red;font-size:14px}

Before bugfix

@import"https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css" screenand (min-width:640px)@import"https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css";div{color:red;font-size:14px}

After bugfix

@import"https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css" screenand (min-width:640px);@import"https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css";div{color:red;font-size:14px}

add ';'to module.media

5c365d3

Copy link

linux-foundation-easyclabot commentedSep 11, 2023•
edited
Loading

The committers listed above are authorized under a signed CLA.

✅ login: Fi2zz / name: Fitzz (5c365d3)

Fi2zz marked this pull request as draft

September 11, 2023 07:09

Fi2zz marked this pull request as ready for review

September 11, 2023 07:10

alexander-akait reviewed

Dec 20, 2023

View reviewed changes

Copy link

Member

alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, can we add a test case?

Copy link

ContributorAuthor

Fi2zz commentedDec 21, 2023

Looks good, can we add a test case?

please checkhere
@alexander-akait

alexander-akait approved these changes

Dec 22, 2023

View reviewed changes

alexander-akait closed this

Dec 22, 2023

alexander-akait reopened this

Dec 22, 2023

Copy link

codecovbot commentedDec 22, 2023

Codecov Report

Attention:1 lines in your changes are missing coverage. Please review.

Comparison is base(d5e540b) 90.54% compared to head(5c365d3) 89.96%.
Report is 2 commits behind head on master.

Files	Patch %	Lines
src/index.js	0.00%	1 Missing⚠️

Additional details and impacted files

@@            Coverage Diff             @@##           master    #1051      +/-   ##==========================================- Coverage   90.54%   89.96%   -0.59%==========================================  Files           5        5                Lines         857      857                Branches      243      243              ==========================================- Hits          776      771       -5- Misses         71       75       +4- Partials       10       11       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.