This repository was archived by the owner on Jun 25, 2020. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork59
Support json modules#75
Open
rmja wants to merge1 commit intowebpack-contrib:masterChoose a base branch fromrmja:patch-2
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is a proposal for a fix towebpack-contrib#74. It is not elegant but it gets the job done
jsf-clabot commentedJul 4, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Author
rmja commentedAug 24, 2018
ping. The bug this pr fixes is a showstopper when using json files with webpack 4. |
Author
rmja commentedSep 15, 2018
Ping@michael-ciniawsky, sorry for the noise - any news on this? |
billneff79 commentedNov 20, 2018
I can verify that this PR also fixes the issue for me with no adverse side effects that I notice. Would be great to get this, or an equivalent, merged@michael-ciniawsky |
maksis commentedFeb 18, 2019
This PR also fixed the issue for me. Are there other maintainers than@michael-ciniawsky who could check this pull request? |
Author
rmja commentedJan 29, 2020
@michael-ciniawsky Could you comment on this? Or maybe point us to someone who would be able to review this? |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal for a fix to#74. It is not elegant but it gets the job done.
The way the NormalModuleFactory is found from the dependencyFactories is probably not the right way to do it, but I don't have a good enough understanding on how to do this stuff, and this is the proposal I was able to come up with:-)
The example environment that this PR is fixing is:
index.js:
test.json:
Without this fix, this currently returns the error: