Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Responsive sponsor ad#7228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
JamesSwinton wants to merge4 commits intowebpack:main
base:main
Choose a base branch
Loading
fromJamesSwinton:responsiveSponsorAd

Conversation

JamesSwinton
Copy link
Contributor

I have updated the AG Grid sponsor section so that it appears on small & mobile devices.

@vercelVercel
Copy link

vercelbot commentedApr 11, 2024

@JamesSwinton is attempting to deploy a commit to theWebpack Docs Team onVercel.

A member of the Team first needs toauthorize it.

@alexander-akait
Copy link
Member

@JamesSwinton Can you add screenshots before/after, thank you

@JamesSwinton
Copy link
ContributorAuthor

JamesSwinton commentedApr 11, 2024•
edited
Loading

Hey@alexander-akait, sure, no problem:

Before:
Before

After:
After

alexander-akait
alexander-akait previously approved these changesApr 11, 2024
@alexander-akait
Copy link
Member

Can you rebase?

@JamesSwinton
Copy link
ContributorAuthor

Should be ready to merge now, thanks

@chenxsan
Copy link
Member

chenxsan commentedMay 27, 2024•
edited
Loading

Not sure we want to show ads on top of small screens, it would be terrible UX IMO.

@snitin315
Copy link
Member

I agree, showing add on top would shift the content below leading to a degraded UX. Maybe we can do something similar toESLint, it moves the ad to the footer on small screens.

Screenshot 2024-06-04 at 6 05 52 AM

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alexander-akaitalexander-akaitalexander-akait left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@JamesSwinton@alexander-akait@chenxsan@snitin315
[8]ページ先頭
©2009-2025 Movatter.jp