Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.5k
Issue 4630/replace default gateway#5255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Issue 4630/replace default gateway#5255
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Please remove unrelated changes, thank you |
dab3db4 tod744c9eCompared744c9e tob5784a1Compare
done. |
| *@param {string} gateway | ||
| *@returns {string | undefined} | ||
| */ | ||
| staticfindIp(gateway){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We need to keep this function, because developer still can use it, otherwise it is a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ok, I'll change my changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
codecovbot commentedAug 6, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #5255 +/- ##==========================================- Coverage 90.29% 84.99% -5.31%========================================== Files 15 16 +1 Lines 1577 1693 +116 Branches 601 635 +34 ==========================================+ Hits 1424 1439 +15- Misses 140 227 +87- Partials 13 27 +14 ☔ View full report in Codecov by Sentry. |
/cc@snitin315 Feel free to merge when CI will be green, locally all tests are passed |
This is a mirror ofwebpack/webpack-dev-server#5255Fixeslynx-family#83
This is a mirror ofwebpack/webpack-dev-server#5255Fixeslynx-family#83
This is a mirror ofwebpack/webpack-dev-server#5255Fixes#83<!-- Thank you for submitting a pull request!We appreciate the time and effort you have invested in making thesechanges. Please ensure that you provide enough information to allowothers to review your pull request.Upon submission, your pull request will be automatically assigned withreviewers.If you want to learn more about contributing to this project, pleasevisit:https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md.-->## Summary<!-- Can you explain the reasoning behind implementing this change? Whatproblem or issue does this pull request resolve? --><!-- It would be helpful if you could provide any relevant context, suchas GitHub issues or related discussions. -->## Checklist<!--- Check and mark with an "x" -->- [ ] Tests updated (or not required).- [ ] Documentation updated (or not required).
For Bugs and Features; did you add new tests?
there are failing tests in#5080 which will be fixed and new tests will be added in case.
Motivation / Use-Case
fixes#4630
Breaking Changes
Additional Info