Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.5k
fix(deps): Replacerimraf withrm, moverimraf to a dev dep#5162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
alexander-akait approved these changesApr 24, 2024
Great job 👍 |
ContributorAuthor
askoufis commentedApr 24, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Should I rename the commit and force push so commitlint will pass? |
Ignore it, I will rename when will merge |
Looks like github actions is down -https://www.githubstatus.com/, I will rerun it when it will work |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
For Bugs and Features; did you add new tests?
No fixes or features
Motivation / Use-Case
Now that this package's minimum supported node version is high enough, and given the relatively simple use case that
rimrafis used for at runtime, IMO it's worth just using node'srminstead (viagraceful-fs).There is one more
rimrafusage inside a test, but I figured that could stay. Happy to remove that too, thoughrimrafis still used as a CLI so it has to stay at least as a dev dep.Breaking Changes
None
Additional Info
None