refactor!: remove the deprecated constructor API#4808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

alexander-akait merged 2 commits intonextfromfix/rm-old-constructor-api

Apr 7, 2023

Merged

refactor!: remove the deprecated constructor API#4808

alexander-akait merged 2 commits intonextfromfix/rm-old-constructor-api

Apr 7, 2023

Conversation

Copy link

Member

snitin315 commentedApr 7, 2023•
edited
Loading

This is abugfix
This is afeature
This is acode refactor
This is atest update
This is adocs update
This is ametadata update

For Bugs and Features; did you add new tests?

Removed deprecated tests.

Motivation / Use-Case

Resolve TODO and the remove old API.

Breaking Changes

BREAKING CHANGE: The deprecated constructor API has been removed. Please useoptions as the first argument andcompiler as the second argument.

Additional Info

CLI is compatible

https://github.com/webpack/webpack-cli/blob/a67dee4facb926c3a041266632e294084542a268/packages/serve/src/index.ts#L229

refactor!: remove the deprecated constructor API

05ff734

snitin315 requested review fromalexander-akait,anshumanv andhiroppy ascode owners

April 7, 2023 03:14

Copy link

codecovbot commentedApr 7, 2023•
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change:+0.10 🎉

Comparison is base(22d6f32) 92.09% compared to head(0fab758) 92.20%.

Additional details and impacted files

@@            Coverage Diff             @@##             next    #4808      +/-   ##==========================================+ Coverage   92.09%   92.20%   +0.10%==========================================  Files          15       15                Lines        1544     1539       -5       Branches      575      573       -2     ==========================================- Hits         1422     1419       -3+ Misses        113      111       -2  Partials        9        9